Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Unified Diff: freetype/truetype/truetype_test.go

Issue 34700043: code review 34700043: freetype/truetype: load vertical metrics from the OS/2 ... (Closed)
Patch Set: diff -r 5c5f2cbdf93a https://code.google.com/p/freetype-go Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « freetype/truetype/truetype.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: freetype/truetype/truetype_test.go
===================================================================
--- a/freetype/truetype/truetype_test.go
+++ b/freetype/truetype/truetype_test.go
@@ -261,22 +261,6 @@
{"x-times-new-roman", 13, 0},
}
-var scalingExceptions = map[string]map[int]bool{
- // TODO: fix these exceptions now that C Freetype version 2.5.1 is released:
- // see http://lists.nongnu.org/archive/html/freetype/2013-11/msg00004.html
- "x-deja-vu-sans-oblique": map[int]bool{
- 269: true,
- 733: true,
- 734: true,
- 2071: true,
- 2072: true,
- 2077: true,
- 2078: true,
- 2171: true,
- 2172: true,
- },
-}
-
// TODO: also test bounding boxes, not just points.
func testScaling(t *testing.T, hinter *Hinter) {
@@ -329,7 +313,6 @@
continue
}
- exceptions := scalingExceptions[tc.name]
glyphBuf := NewGlyphBuf()
for i, want := range wants {
// TODO: completely implement hinting. For now, only the first
@@ -338,10 +321,6 @@
break
}
- if exceptions != nil && exceptions[i] {
- continue
- }
-
if err = glyphBuf.Load(font, tc.size*64, Index(i), hinter); err != nil {
t.Errorf("%s: glyph #%d: Load: %v", tc.name, i, err)
continue
« no previous file with comments | « freetype/truetype/truetype.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b