freetype/truetype/glyph.go - Issue 34700043: code review 34700043: freetype/truetype: load vertical metrics from the OS/2 ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: freetype/truetype/glyph.go

Issue 34700043: code review 34700043: freetype/truetype: load vertical metrics from the OS/2 ... (Closed)

Patch Set: diff -r 5c5f2cbdf93a https://code.google.com/p/freetype-go Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: freetype/truetype/glyph.go

===================================================================

--- a/freetype/truetype/glyph.go

+++ b/freetype/truetype/glyph.go

@@ -377,12 +377,12 @@

func (g *GlyphBuf) addPhantomsAndScale(b Bounds, uhm HMetric, i Index, np0 int, simple bool) {

// Add the four phantom points.

- uvm := g.font.unscaledVMetric(i)

+ uvm := g.font.unscaledVMetric(i, b.YMax)

g.Point = append(g.Point,

Point{X: b.XMin - uhm.LeftSideBearing},

Point{X: b.XMin - uhm.LeftSideBearing + uhm.AdvanceWidth},

- Point{Y: b.YMax + uvm.TopSideBearing},

- Point{Y: b.YMax + uvm.TopSideBearing - uvm.AdvanceHeight},

+ Point{X: uhm.AdvanceWidth / 2, Y: b.YMax + uvm.TopSideBearing},

+ Point{X: uhm.AdvanceWidth / 2, Y: b.YMax + uvm.TopSideBearing - uvm.AdvanceHeight},

)

// Scale the points.

if simple && g.hinter != nil {

« no previous file with comments | « no previous file | freetype/truetype/truetype.go » ('j') | no next file with comments »