Issue 3453042: code review 3453042: go/parser: Better comment for ParseFile.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3453042: code review 3453042: go/parser: Better comment for ParseFile. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by gri

Modified:
14 years, 3 months ago

Reviewers:

CC:
r, rsc, golang-dev

Visibility:
Public.

Description

go/parser: Better comment for ParseFile. The name ParseFile was kept as it indicates that this function parses a Go 'SourceFile' per the Go spec. Similarly, the other functions (ParseExpr, ParseStmtList, ParseDeclList) parse the corresponding constructs as defined in the Go spec. Fixes issue 1311.

Patch Set 1 #

Patch Set 2 : code review 3453042: go/parser: Better comment for ParseFile. #

Total comments: 1

Patch Set 3 : code review 3453042: go/parser: Better comment for ParseFile. #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	src/pkg/go/parser/interface.go	View	1 2	1 chunk	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-12-07 01:01:58 UTC) #1

LGTM modulo one remark http://codereview.appspot.com/3453042/diff/2001/src/pkg/go/parser/interface.go File src/pkg/go/parser/interface.go (right): http://codereview.appspot.com/3453042/diff/2001/src/pkg/go/parser/interface.go#newcode114 src/pkg/go/parser/interface.go:114: // ParseFile parses the source ...

14 years, 3 months ago (2010-12-07 21:25:15 UTC) #2

gri

SourceFile as in ast.SourceFile except that it's ast.File anyhow, so this is obviously a mistake. ...

14 years, 3 months ago (2010-12-07 21:39:26 UTC) #4

gri

14 years, 3 months ago (2010-12-07 21:44:04 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=e49ed088224e ***

go/parser: Better comment for ParseFile.

The name ParseFile was kept as it indicates that
this function parses a Go 'SourceFile' per the
Go spec. Similarly, the other functions (ParseExpr,
ParseStmtList, ParseDeclList) parse the corresponding
constructs as defined in the Go spec.

Fixes issue 1311.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/3453042

Expand All Messages | Collapse All Messages