Issue 3437043: Expose RequestItem parameters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3437043: Expose RequestItem parameters

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by zhoresh

Modified:
15 years, 2 months ago

Reviewers:
johnfargo, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

I need to be able to iterate over the request parameters, so adding a get of parameters map.

Patch Set 2 : Updated to use unmodifiable map #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
		java/common/src/main/java/org/apache/shindig/protocol/BaseRequestItem.java	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

johnfargo

http://codereview.appspot.com/3437043/diff/1/java/common/src/main/java/org/apache/shindig/protocol/BaseRequestItem.java File java/common/src/main/java/org/apache/shindig/protocol/BaseRequestItem.java (right): http://codereview.appspot.com/3437043/diff/1/java/common/src/main/java/org/apache/shindig/protocol/BaseRequestItem.java#newcode243 java/common/src/main/java/org/apache/shindig/protocol/BaseRequestItem.java:243: return this.parameters; return Collections.unmodifiableMap(...)

15 years, 2 months ago (2010-12-08 19:27:28 UTC) #2

johnfargo

LGTM A test to ensure unmodifiability would be nice but not strictly necessary.

15 years, 2 months ago (2010-12-08 22:17:22 UTC) #4

zhoresh

15 years, 2 months ago (2010-12-09 00:19:23 UTC) #5

On 2010/12/08 22:17:22, johnfargo wrote:
> LGTM
> 
> A test to ensure unmodifiability would be nice but not strictly necessary.

Thanks, test was added and code submitted at r1043770

Expand All Messages | Collapse All Messages