code review 3427043: throughout: fix broken calls to Printf etc.

throughout: fix broken calls to Printf etc.
I have written a tool to verify Printf calls, and although it's not
ready to be reviewed yet it's already uncovered a spate of problems
in the repository.  I'm sending this CL to break the changes into
pieces; as the tool improves it will find more, I'm sure.

[r, 2010-12-07 21:33:11]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-12-07 21:36:02]

LGTM

http://codereview.appspot.com/3427043/diff/1/src/pkg/go/printer/printer_test.go
File src/pkg/go/printer/printer_test.go (right):

http://codereview.appspot.com/3427043/diff/1/src/pkg/go/printer/printer_test....
src/pkg/go/printer/printer_test.go:101: t.Error("\n")
t.Error() seems fine to me
error adds the \n anyway

[r, 2010-12-07 21:42:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=af890ea71a19 ***

throughout: fix broken calls to Printf etc.
I have written a tool to verify Printf calls, and although it's not
ready to be reviewed yet it's already uncovered a spate of problems
in the repository.  I'm sending this CL to break the changes into
pieces; as the tool improves it will find more, I'm sure.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3427043

[rh, 2010-12-07 22:25:24]

Sorry to nitpick.

http://codereview.appspot.com/3427043/diff/5001/src/pkg/path/path_test.go
File src/pkg/path/path_test.go (right):

http://codereview.appspot.com/3427043/diff/5001/src/pkg/path/path_test.go#new...
src/pkg/path/path_test.go:260: t.Error("no error expected, found: s", err)
Is this right?  This looks like it was trying to be either:
t.Errorf("no error expected, found: %s", err)
or:
t.Error("no error expected, found: ", err)