Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(88)

Issue 3423043: code review 3423043: fmt: add %U format for standard Unicode representation ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by r
Modified:
14 years, 3 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

fmt: add %U format for standard Unicode representation of integer values. fmt.Printf("%U", 1) yields "U+0001" It's essentially "U+%.4x" but lets you override the precision works in scan, too.

Patch Set 1 #

Total comments: 1

Patch Set 2 : code review 3423043: fmt: add %U format for standard Unicode representation ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -10 lines) Patch
M src/pkg/fmt/doc.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/fmt/fmt_test.go View 1 chunk +8 lines, -0 lines 0 comments Download
M src/pkg/fmt/format.go View 3 chunks +8 lines, -0 lines 0 comments Download
M src/pkg/fmt/print.go View 3 chunks +20 lines, -1 line 0 comments Download
M src/pkg/fmt/scan.go View 6 chunks +28 lines, -9 lines 0 comments Download
M src/pkg/fmt/scan_test.go View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 3 months ago (2010-12-04 22:51:43 UTC) #1
rsc1
LGTM motivation seems a little weak but okay. it is a standard format. http://codereview.appspot.com/3423043/diff/1/src/pkg/fmt/doc.go File ...
14 years, 3 months ago (2010-12-06 19:20:03 UTC) #2
r
14 years, 3 months ago (2010-12-06 19:23:39 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=e2d2cc32574d ***

fmt: add %U format for standard Unicode representation of integer values.
	fmt.Printf("%U", 1) yields "U+0001"
It's essentially "U+%.4x" but lets you override the precision works in scan,
too.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3423043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b