Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1780)

Issue 342240043: Issue 5402: Arrange for System::get_bound to return a Paper_column (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 1 week ago by Dan Eble
Modified:
10 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5402/ Arrange for System::get_bound to return a Paper_column Enforce that only Paper_columns may be set as bounds of Systems. Whether an Item and a Spanner can be linked depends on the specific type of each, so we use two virtual function calls to simulate multiple dispatch. This is part of a campaign to preserve more type information in the C++ code, with the goal of reducing the amount of run-time type checking and conditional code.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -24 lines) Patch
M lily/include/grob.hh View 2 chunks +1 line, -1 line 0 comments Download
M lily/include/item.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/paper-column.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/spanner.hh View 1 chunk +5 lines, -1 line 0 comments Download
M lily/include/system.hh View 2 chunks +7 lines, -0 lines 0 comments Download
M lily/item.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/paper-column.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M lily/spanner.cc View 3 chunks +21 lines, -20 lines 0 comments Download
M lily/system.cc View 2 chunks +14 lines, -2 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b