Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(746)

Issue 3422041: Fix 1252 by compressing page (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by Carl
Modified:
3 years, 4 months ago
Reviewers:
joeneeman, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix 1252 by compressing page

Patch Set 1 #

Total comments: 6

Patch Set 2 : Respond to Neil's comments #

Patch Set 3 : Add regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
A input/regression/page-overflow-compression.ly View 1 chunk +17 lines, -0 lines 0 comments Download
M lily/page-layout-problem.cc View 1 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Carl
Here's a patch to fix issue 1252 (music overflows page) by compressing music together. It ...
3 years, 4 months ago #1
joeneeman
On 2010/12/02 20:52:00, Carl wrote: > Here's a patch to fix issue 1252 (music overflows ...
3 years, 4 months ago #2
Neil Puttock
http://codereview.appspot.com/3422041/diff/1/lily/page-layout-problem.cc File lily/page-layout-problem.cc (right): http://codereview.appspot.com/3422041/diff/1/lily/page-layout-problem.cc#newcode313 lily/page-layout-problem.cc:313: double overflow = spacer.configuration_length (spacer.force ()) - Real overflow ...
3 years, 4 months ago #3
Carl
3 years, 4 months ago #4
Thanks for the review, Neil.

http://codereview.appspot.com/3422041/diff/1/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):

http://codereview.appspot.com/3422041/diff/1/lily/page-layout-problem.cc#newc...
lily/page-layout-problem.cc:313: double overflow = spacer.configuration_length
(spacer.force ()) -
On 2010/12/02 21:33:19, Neil Puttock wrote:
> Real overflow

Done.

http://codereview.appspot.com/3422041/diff/1/lily/page-layout-problem.cc#newc...
lily/page-layout-problem.cc:314: page_height_;
On 2010/12/02 21:33:19, Neil Puttock wrote:
> indent
> 

Done.

http://codereview.appspot.com/3422041/diff/1/lily/page-layout-problem.cc#newc...
lily/page-layout-problem.cc:320: warning (_f ("compressing music to fit"));
On 2010/12/02 21:33:19, Neil Puttock wrote:
> (_ (

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5