Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)

Issue 340980043: Issue 5299: Place the MIDI end-of-track event (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by Dan Eble
Modified:
1 year, 1 month ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5299/ Place the MIDI end-of-track event at the moment the responsible performer is finalized rather than always making it simultaneous with the penultimate event of the track. Before this change, the MIDI output for a muscal part ending in a rest was marked as ending at the beginning of the rest. Perhaps few people care, but it bothered me. Also, use Moments rather than ticks in the Audio_staff interface because ticks are a detail of MIDI.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -10 lines) Patch
M lily/audio-staff.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M lily/control-track-performer.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M lily/include/audio-staff.hh View 1 chunk +4 lines, -1 line 0 comments Download
M lily/include/midi-chunk.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/midi-item.hh View 1 chunk +10 lines, -0 lines 0 comments Download
M lily/include/midi-walker.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/midi-chunk.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M lily/midi-walker.cc View 1 chunk +3 lines, -1 line 0 comments Download
M lily/performance.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/staff-performer.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Dan Eble
1 year, 1 month ago (2018-03-29 22:34:05 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b