Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 340780043: ui/gtk3: Load Unicode data when open the dialog by default (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by fujiwara
Modified:
6 years, 1 month ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ui/gtk3: Load Unicode data when open the dialog by default The emoji data requires about 10MB and the Unicode data requires about 15MB. Now the emoji data is loaded at the time of startup and the Unicode data is loaded if users open the dialog at the beginning. The settings can be customized with gsettings command and the keys of 'load-emoji-at-startup' and 'load-unicode-at-startup' in 'org.freedesktop.ibus.panel.emoji' schema. Committed: fc54b0c051c2eb4a2c1f836b1415def00314cfc1

Patch Set 1 #

Patch Set 2 : Updated with the latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -2 lines) Patch
M data/ibus.schemas.in View 1 chunk +32 lines, -0 lines 0 comments Download
M ui/gtk3/panelbinding.vala View 6 chunks +39 lines, -2 lines 0 comments Download

Messages

Total messages: 3
fujiwara
6 years, 1 month ago (2018-02-20 14:01:07 UTC) #1
Peng
lgtm
6 years, 1 month ago (2018-02-20 15:00:22 UTC) #2
fujiwara
6 years, 1 month ago (2018-02-21 03:17:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fc54b0c051c2eb4a2c1f836b1415def00314cfc1 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b