Issue 340710043: [dfvfs] Added list file entries end-to-end tests #291

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 340710043: [dfvfs] Added list file entries end-to-end tests #291 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 6 months ago by Joachim Metz

Modified:
7 years, 4 months ago

Reviewers:
jberggren, onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[dfvfs] Added list file entries end-to-end tests #291

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+310 lines, -93 lines)			Patch
M	config/end-to-end.ini	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	examples/list_file_entries.py	View	6 chunks	+99 lines, -36 lines	0 comments	Download
M	examples/recursive_hasher.py	View	4 chunks	+5 lines, -8 lines	2 comments	Download
A	test_data/end_to_end/image.qcow2.paths	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	test_data/end_to_end/image.vmdk.paths	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	tests/end-to-end.py	View	6 chunks	+179 lines, -49 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

onager

LGTM https://codereview.appspot.com/340710043/diff/1/examples/recursive_hasher.py File examples/recursive_hasher.py (right): https://codereview.appspot.com/340710043/diff/1/examples/recursive_hasher.py#newcode19 examples/recursive_hasher.py:19: from dfvfs.analyzer import analyzer as analyzer -as analyzer

7 years, 5 months ago (2018-05-31 15:15:35 UTC) #2

Joachim Metz

Changes have been merged with master branch. To close the review and clean up the ...

7 years, 4 months ago (2018-06-01 04:07:18 UTC) #3

Joachim Metz

7 years, 4 months ago (2018-06-01 04:14:53 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/340710043/diff/1/examples/recursive_hasher.py
File examples/recursive_hasher.py (right):

https://codereview.appspot.com/340710043/diff/1/examples/recursive_hasher.py#...
examples/recursive_hasher.py:19: from dfvfs.analyzer import analyzer as analyzer
On 2018/05/31 15:15:35, onager wrote:
> -as analyzer

Done.

Expand All Messages | Collapse All Messages