Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6221)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 340190043: Implement Unicode choice on Emojier (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by fujiwara
Modified:
6 years, 2 months ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Implement Unicode choice on Emojier BUG=https://github.com/ibus/ibus/issues/1922 Committed: e17c99859d06ab75326730e45072e1061f7d87c7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add ibusunicodege.h #

Patch Set 3 : Added panel.vala and re-allocation for some chars #

Patch Set 4 : Fix a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3613 lines, -76 lines) Patch
M configure.ac View 3 chunks +39 lines, -2 lines 0 comments Download
M po/POTFILES.in View 1 chunk +1 line, -0 lines 0 comments Download
M src/Makefile.am View 7 chunks +54 lines, -1 line 0 comments Download
M src/emoji-parser.c View 2 chunks +2 lines, -1 line 0 comments Download
M src/ibus.h View 2 chunks +3 lines, -1 line 0 comments Download
A src/ibusunicode.h View 1 chunk +299 lines, -0 lines 0 comments Download
A src/ibusunicode.c View 1 chunk +1069 lines, -0 lines 0 comments Download
A src/ibusunicodegen.h View 1 1 chunk +1151 lines, -0 lines 0 comments Download
A src/unicode-parser.c View 1 1 chunk +502 lines, -0 lines 0 comments Download
M ui/gtk3/emojier.vala View 1 2 3 34 chunks +481 lines, -69 lines 0 comments Download
M ui/gtk3/emojierapp.vala View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gtk3/ibusemojidialog.h View 2 chunks +8 lines, -1 line 0 comments Download
M ui/gtk3/panel.vala View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9
fujiwara
6 years, 3 months ago (2018-01-26 13:31:47 UTC) #1
Peng
On 2018/01/26 13:31:47, fujiwara wrote: lgtm
6 years, 3 months ago (2018-01-26 15:21:37 UTC) #2
baby546833
baby546833@gmail.com=周訓毅，盜用老婆帳號被發現後就常常打老婆出氣 https://codereview.appspot.com/340190043/diff/1/configure.ac File configure.ac (left): https://codereview.appspot.com/340190043/diff/1/configure.ac#oldcode637 configure.ac:637: else 臭雞歪 https://codereview.appspot.com/340190043/diff/1/configure.ac#oldcode646 configure.ac:646: https://github.com/fujiwarat/cldr-emoji-annotation) 幹你娘
6 years, 2 months ago (2018-01-27 02:51:12 UTC) #3
baby546833
baby546833@gmail.com=周訓毅，盜用老婆帳號被發現後就常常打老婆出氣
6 years, 2 months ago (2018-01-27 02:52:25 UTC) #4
baby546833
On 2018/01/26 13:31:47, fujiwara wrote: 我 baby546833@gmail.com =週訓毅，盜用老婆帳號被發現後就常常打老婆出氣
6 years, 2 months ago (2018-01-27 02:53:07 UTC) #5
baby546833
我 baby546833@gmail.com =週訓毅，盜用老婆帳號被發現後就常常打老婆出氣
6 years, 2 months ago (2018-01-27 02:54:22 UTC) #6
baby546833
我 baby546833@gmail.com =週訓毅，盜用老婆帳號被發現後就常常打老婆出氣
6 years, 2 months ago (2018-01-27 02:54:55 UTC) #7
baby546833
me=baby546833@gmail.com
6 years, 2 months ago (2018-01-27 02:59:15 UTC) #8
fujiwara
6 years, 2 months ago (2018-01-29 07:50:20 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
e17c99859d06ab75326730e45072e1061f7d87c7 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b