Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2826)

Issue 339780043: Eliminate Visual Studio compiler warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by ammo6818-vandals.uidaho.edu
Modified:
11 months, 2 weeks ago
Reviewers:
Vedran Miletić
Visibility:
Public.

Description

Eliminate Visual Studio compiler warnings

Patch Set 1 #

Patch Set 2 : Updates to use C++ style type casts #

Patch Set 3 : Patch updates for x64 build #

Patch Set 4 : Update patch per coding style requirements #

Patch Set 5 : Update patch with latest module changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -151 lines) Patch
M src/network/helper/application-container.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/network/helper/net-device-container.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/network/helper/node-container.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/network/helper/trace-helper.h View 9 chunks +9 lines, -0 lines 0 comments Download
M src/network/model/address.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/network/model/buffer.h View 1 2 3 4 chunks +24 lines, -0 lines 0 comments Download
M src/network/model/buffer.cc View 1 2 3 3 chunks +24 lines, -3 lines 0 comments Download
M src/network/model/byte-tag-list.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/network/model/channel-list.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/network/model/chunk.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/network/model/nix-vector.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/network/model/node.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M src/network/model/node-list.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/network/model/packet.cc View 1 2 5 chunks +5 lines, -4 lines 0 comments Download
M src/network/model/packet-metadata.cc View 1 2 3 16 chunks +33 lines, -33 lines 0 comments Download
M src/network/model/packet-tag-list.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/network/model/socket.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/network/model/socket.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/network/model/trailer.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/network/test/buffer-test.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M src/network/test/error-model-test-suite.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M src/network/test/packet-metadata-test.cc View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M src/network/test/packet-socket-apps-test-suite.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/network/test/packet-test-suite.cc View 1 2 3 3 chunks +27 lines, -25 lines 0 comments Download
M src/network/test/packetbb-test-suite.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/network/test/pcap-file-test-suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/network/utils/address-utils.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/network/utils/data-rate.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M src/network/utils/error-channel.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/network/utils/error-model.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/network/utils/ipv6-address.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/network/utils/mac16-address.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/network/utils/mac48-address.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/network/utils/mac64-address.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/network/utils/net-device-queue-interface.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/network/utils/packet-burst.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/network/utils/packet-data-calculators.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M src/network/utils/packet-socket.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/network/utils/packet-socket-address.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/network/utils/packetbb.cc View 1 2 3 13 chunks +14 lines, -16 lines 0 comments Download
M src/network/utils/pcap-file-wrapper.cc View 1 2 3 4 chunks +9 lines, -8 lines 0 comments Download
M src/network/utils/queue-item.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M src/network/utils/queue-size.cc View 1 2 3 2 chunks +11 lines, -11 lines 0 comments Download
M src/network/utils/radiotap-header.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/network/utils/simple-channel.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/network/utils/sll-header.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
ammo6818-vandals.uidaho.edu
1 year, 10 months ago (2018-03-15 02:57:47 UTC) #1
Patch updated with latest module changes
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b