Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(174)

Issue 339300043: Implement ibus-extension-gtk3 for the global keybinding (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by fujiwara
Modified:
6 years, 2 months ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Implement ibus-extension-gtk3 for the global keybinding Currently IBus panel (ibus-ui-gtk3) is not available in GNOME and Plasma so the emoji and unicode point typings are not available in GNOME and Plasma. The workaround `ibus emoji` command is available but it put the selected character into the copy buffer and users have to paste the character. Originaly the emoji feature was implemented in IBus GtkIMModule but it had several problems; the first is the keybinding is hard-coded and IBus GtkIMModule does not use GSettings for the customized settings. The second is the feature was available for GTK applications. The third is that XKB input sources uses gtk-im-context-simple but not ibus in GNOME desktop so users have to add an IM input sources to enable IBus for the XKB input sources. The fourth is the feature was available for IBusEngineSimple only and other IBus IMEs need to inherit that class to get the emoji feature. The fifth is that emoji typing is available for English only since IBusEngineSimple had the feature. The sixth is that the default one dimension lookup window was not useful to choose an emoji and needed two dimensions lookup window. And the implementation was moved from IBus GtkIMModule to IBus panel to fix above problems. But users have to use `ibus emoji` at present if ibus-ui-gtk3 is not available. Now I think to move the emoji feature from ibus-ui-gtk3 to another IBus component; ibus-extension-gtk3 which manages the Ctrl-Shift-e. GNOME and Plasma desktops still do not show the GUI menu but the shortcut key is available in this implementation. BUG=RHBZ#1430501 R=Shawn.P.Huang@gmail.com Committed: fb07f64764f18f702221ff5574b2fd2193f051f0

Patch Set 1 #

Patch Set 2 : Fix a typo #

Patch Set 3 : Fix a typo #

Patch Set 4 : Fix a typo #

Patch Set 5 : Fix make check #

Patch Set 6 : Update ibus-daemon argument #

Patch Set 7 : Handle PanelExtensionReceived without extension #

Patch Set 8 : Add a warning #

Patch Set 9 : Revert Patch Set 8. #

Patch Set 10 : Stop the disable command at the moment #

Patch Set 11 : Reverted Patch Set 10 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2393 lines, -506 lines) Patch
M bindings/vala/IBus-1.0-custom.vala View 1 chunk +4 lines, -0 lines 0 comments Download
M bus/Makefile.am View 2 chunks +6 lines, -1 line 0 comments Download
M bus/ibusimpl.c View 1 2 3 4 5 6 7 8 9 chunks +66 lines, -16 lines 0 comments Download
M bus/main.c View 1 2 3 4 5 10 4 chunks +24 lines, -1 line 0 comments Download
M bus/marshalers.list View 1 chunk +1 line, -0 lines 0 comments Download
M bus/panelproxy.h View 3 chunks +18 lines, -2 lines 0 comments Download
M bus/panelproxy.c View 7 chunks +51 lines, -6 lines 0 comments Download
M src/Makefile.am View 3 chunks +3 lines, -1 line 0 comments Download
M src/ibus.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ibusmarshalers.list View 1 chunk +1 line, -0 lines 0 comments Download
M src/ibuspanelservice.h View 3 chunks +14 lines, -1 line 0 comments Download
M src/ibuspanelservice.c View 1 11 chunks +80 lines, -1 line 0 comments Download
M src/ibusserializable.h View 4 chunks +12 lines, -6 lines 0 comments Download
M src/ibusserializable.c View 3 chunks +4 lines, -3 lines 0 comments Download
M src/ibusshare.h View 3 chunks +16 lines, -1 line 0 comments Download
M src/ibusshare.c View 2 chunks +3 lines, -1 line 0 comments Download
A src/ibusxevent.h View 1 chunk +294 lines, -0 lines 0 comments Download
A src/ibusxevent.c View 1 chunk +1004 lines, -0 lines 0 comments Download
M src/tests/runtest View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ui/gtk3/Makefile.am View 1 2 3 6 chunks +54 lines, -5 lines 0 comments Download
A ui/gtk3/bindingcommon.vala View 1 chunk +215 lines, -0 lines 0 comments Download
M ui/gtk3/candidatearea.vala View 1 chunk +0 lines, -102 lines 0 comments Download
A + ui/gtk3/extension.vala View 5 chunks +11 lines, -11 lines 0 comments Download
A ui/gtk3/gtkextension.xml.in View 1 chunk +12 lines, -0 lines 0 comments Download
M ui/gtk3/iconwidget.vala View 2 chunks +103 lines, -0 lines 0 comments Download
M ui/gtk3/panel.vala View 20 chunks +60 lines, -348 lines 0 comments Download
A ui/gtk3/panelbinding.vala View 1 chunk +335 lines, -0 lines 0 comments Download

Messages

Total messages: 3
fujiwara
6 years, 2 months ago (2018-02-15 14:04:10 UTC) #1
Peng
On 2018/02/15 14:04:10, fujiwara wrote: Lgtm
6 years, 2 months ago (2018-02-19 12:38:59 UTC) #2
fujiwara
6 years, 2 months ago (2018-02-20 08:25:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #11 (id:200001) manually as
fb07f64764f18f702221ff5574b2fd2193f051f0 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b