Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 339270043: Allow left-handed fret-markups

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by thomasmorley651
Modified:
1 year, 7 months ago
Reviewers:
dak, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allow left-handed fret-markups By adding a new boolean subproperty: left-handed. - Extends Documentation/notation/fretted-strings.itely - Extends Documentation/changes.tely - Extenss scm/define-grob-properties.scm - Adds regtest input/regression/fret-diagrams-left-handed.ly - Disables the possibility to use negative string-distance

Patch Set 1 #

Total comments: 1

Patch Set 2 : David's suggestion #

Patch Set 3 : oversight #

Patch Set 4 : fix glitch exposed by fret-diagram-origin.ly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -8 lines) Patch
M Documentation/changes.tely View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M Documentation/notation/fretted-strings.itely View 1 1 chunk +14 lines, -0 lines 0 comments Download
A input/regression/fret-diagrams-left-handed.ly View 1 1 chunk +32 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 1 chunk +4 lines, -0 lines 0 comments Download
M scm/fret-diagrams.scm View 1 2 3 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 8
thomasmorley651
please review
1 year, 7 months ago (2018-01-22 22:12:48 UTC) #1
Carl
Looks good to me, but I have one suggestion. Thanks, Carl https://codereview.appspot.com/339270043/diff/1/scm/fret-diagrams.scm File scm/fret-diagrams.scm (right): ...
1 year, 7 months ago (2018-01-22 23:52:29 UTC) #2
thomasmorley651
On 2018/01/22 23:52:29, Carl wrote: > Looks good to me, but I have one suggestion. ...
1 year, 7 months ago (2018-01-23 09:30:15 UTC) #3
dak
thomasmorley65@gmail.com writes: > Yep, the difference between left- and right-handed are certain negative > instead ...
1 year, 7 months ago (2018-01-23 09:55:04 UTC) #4
thomasmorley651
On 2018/01/23 09:55:04, dak wrote: > mailto:thomasmorley65@gmail.com writes: > > > Yep, the difference between ...
1 year, 7 months ago (2018-01-23 10:42:26 UTC) #5
thomasmorley651
David's suggestion
1 year, 7 months ago (2018-01-24 21:29:09 UTC) #6
thomasmorley651
oversight
1 year, 7 months ago (2018-01-24 21:46:13 UTC) #7
thomasmorley651
1 year, 7 months ago (2018-01-25 21:13:43 UTC) #8
fix glitch exposed by fret-diagram-origin.ly
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b