Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in

Issue 339220043: Let Key_performer heed instrumentTransposition

Can't Edit
Can't Publish+Mail
Start Review
1 year, 8 months ago by dak
1 year, 8 months ago
Dan Eble


Let Key_performer heed instrumentTransposition I actually have no good idea how to regtest this one.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M lily/key-performer.cc View 2 chunks +6 lines, -1 line 0 comments Download


Total messages: 1
Dan Eble
1 year, 8 months ago (2018-01-17 00:07:30 UTC) #1
LGTM.  Thanks.

For regression testing, I recall that when I changed the dynamic performer,
there were many MIDI tests in a subdirectory that showed differences in the form
of hex dumps.  They're definitely underwhelming compared to the visual
regression tests, but still better than nothing.

I have no idea whether the MIDI test harness will produce testable output for a
\key command, but if you have time, it might be worth a try.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b