Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(686)

Issue 339090043: add dynamic n for “niente” to feta

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by Malte Meyn
Modified:
2 years ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

add dynamic n for “niente” to feta For a discussion see the following blog posts and their comment sections: http://lilypondblog.org/2014/02/feta-and-bravura/ http://lilypondblog.org/2014/01/smufl-fonts-in-lilypond/ http://lilypondblog.org/2014/04/using-special-characters-from-smufl-fonts/ The first post mentions also italic numbers for fingerings/tuplets which Feta doesn’t contain yet (issue 5074). The “niente” n is a copied and modified version of the “mezzo” m code. Contains also: add dynamic script \n command for “niente”

Patch Set 1 #

Patch Set 2 : (hopefully) let git-cl create sf issue after 500 server error #

Patch Set 3 : add niente to existing regression test #

Patch Set 4 : make n a bit narrower, get rid of too small crescendo warning #

Patch Set 5 : add /n to encodingdefs.ps #

Total comments: 7

Patch Set 6 : fix encoding vector lengths, add "n" to font-table.ly, add \n to NR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -117 lines) Patch
M Documentation/included/font-table.ly View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/expressive.itely View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M input/regression/dynamics-glyphs.ly View 1 2 3 1 chunk +12 lines, -12 lines 0 comments Download
M ly/dynamic-scripts-init.ly View 2 chunks +2 lines, -1 line 0 comments Download
M mf/feta-dynamics.mf View 1 2 3 2 chunks +125 lines, -0 lines 0 comments Download
M ps/encodingdefs.ps View 1 2 3 4 5 7 chunks +103 lines, -101 lines 0 comments Download

Messages

Total messages: 13
Malte Meyn
(hopefully) let git-cl create sf issue after 500 server error
2 years ago (2017-12-27 13:48:56 UTC) #1
Malte Meyn
On 2017/12/27 13:48:56, Malte Meyn wrote: > (hopefully) let git-cl create sf issue after 500 ...
2 years ago (2017-12-27 13:54:53 UTC) #2
Malte Meyn
add niente to existing regression test
2 years ago (2017-12-27 15:56:09 UTC) #3
lemzwerg
LGTM! However, for my taste, the space between the left and the right leg of ...
2 years ago (2017-12-27 18:27:29 UTC) #4
Malte Meyn
make n a bit narrower, get rid of too small crescendo warning
2 years ago (2017-12-28 10:25:06 UTC) #5
Malte Meyn
On 2017/12/28 10:25:06, Malte Meyn wrote: > make n a bit narrower, get rid of ...
2 years ago (2017-12-28 10:31:56 UTC) #6
Malte Meyn
add /n to encodingdefs.ps
2 years ago (2018-01-01 16:53:31 UTC) #7
Malte Meyn
As I don’t really know what I’m doing here, please have a closer look … ...
2 years ago (2018-01-01 17:01:47 UTC) #8
lemzwerg
https://codereview.appspot.com/339090043/diff/80001/ps/encodingdefs.ps File ps/encodingdefs.ps (right): https://codereview.appspot.com/339090043/diff/80001/ps/encodingdefs.ps#newcode721 ps/encodingdefs.ps:721: /.notdef /.notdef /.notdef /.notdef /.notdef Yes, the encoding vector ...
2 years ago (2018-01-01 17:36:41 UTC) #9
Malte Meyn
On 2018/01/01 17:36:41, lemzwerg wrote: > https://codereview.appspot.com/339090043/diff/80001/ps/encodingdefs.ps#newcode721 > ps/encodingdefs.ps:721: /.notdef /.notdef /.notdef /.notdef /.notdef > ...
2 years ago (2018-01-04 17:19:30 UTC) #10
Malte Meyn
fix encoding vector lengths, add "n" to font-table.ly, add \n to NR
2 years ago (2018-01-04 17:21:30 UTC) #11
lemzwerg
> > Yes, the encoding vector should contain exactly 256 elements. > > This isn’t ...
2 years ago (2018-01-04 18:01:19 UTC) #12
lemzwerg
2 years ago (2018-01-04 18:03:04 UTC) #13
LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b