Issue 338520043: ui/gtk3: Set title string in gnome-shell

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 338520043: ui/gtk3: Set title string in gnome-shell (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 8 months ago by fujiwara

Modified:
6 years, 8 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

ui/gtk3: Set title string in gnome-shell gnome-shell uses .desktop files to get the application title names. Probably the reason is to manage any windows and Xorg and Wayland. BUG=https://mail.gnome.org/archives/gtk-app-devel-list/2018-February/msg00027.html R=Shawn.P.Huang@gmail.com Committed: 56c67b1362344e2ab4a061bcc913c455b190ef20

Patch Set 1 #

Patch Set 2 : Updated POTFILES.in #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -14 lines)			Patch
M	po/POTFILES.in	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/gtk3/Makefile.am	View	1	2 chunks	+27 lines, -0 lines	0 comments	Download
M	ui/gtk3/emojierapp.vala	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	ui/gtk3/extension.vala	View		5 chunks	+16 lines, -11 lines	0 comments	Download
A	ui/gtk3/ibus-extension-gtk3.desktop.in.in	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
A	ui/gtk3/ibus-ui-emojier.desktop.in.in	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	ui/gtk3/panelbinding.vala	View		4 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

6 years, 8 months ago (2018-03-01 06:37:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
56c67b1362344e2ab4a061bcc913c455b190ef20 (presubmit successful).

Expand All Messages | Collapse All Messages