src/pkg/bufio/bufio_test.go - Issue 3364041: code review 3364041: utf8: make EncodeRune's destination the first argument.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/bufio/bufio_test.go

Issue 3364041: code review 3364041: utf8: make EncodeRune's destination the first argument. (Closed)

Patch Set: code review 3364041: utf8: make EncodeRune's destination the first argument. Created 14 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/bufio/bufio_test.go

===================================================================

--- a/src/pkg/bufio/bufio_test.go

+++ b/src/pkg/bufio/bufio_test.go

@@ -337,7 +337,7 @@

// Write the runes out using WriteRune

buf := make([]byte, utf8.UTFMax)

for rune := 0; rune < NRune; rune++ {

- size := utf8.EncodeRune(rune, buf)

+ size := utf8.EncodeRune(buf, rune)

nbytes, err := w.WriteRune(rune)

if err != nil {

t.Fatalf("WriteRune(0x%x) error: %s", rune, err)

@@ -351,7 +351,7 @@

r := NewReader(byteBuf)

// Read them back with ReadRune

for rune := 0; rune < NRune; rune++ {

- size := utf8.EncodeRune(rune, buf)

+ size := utf8.EncodeRune(buf, rune)

nr, nbytes, err := r.ReadRune()

if nr != rune || nbytes != size || err != nil {

t.Fatalf("ReadRune(0x%x) got 0x%x,%d not 0x%x,%d (err=%s)", r, nr, nbytes, r, size, err)

« no previous file with comments | « src/pkg/bufio/bufio.go ('k') | src/pkg/bytes/buffer.go » ('j') | no next file with comments »