src/pkg/strconv/atof_test.go - Issue 3359041: code review 3359041: strconv: Atof on Infs and NaNs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/strconv/atof_test.go

Issue 3359041: code review 3359041: strconv: Atof on Infs and NaNs (Closed)

Patch Set: code review 3359041: strconv: Atof on Infs and NaNs Created 14 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/strconv/atof_test.go

===================================================================

--- a/src/pkg/strconv/atof_test.go

+++ b/src/pkg/strconv/atof_test.go

@@ -37,6 +37,16 @@

{"1e-20", "1e-20", nil},

{"625e-3", "0.625", nil},

+ // NaNs

+ {"nan", "NaN", nil},

+ {"NaN", "NaN", nil},

+ {"NAN", "NaN", nil},

+ // Infs

+ {"inf", "+Inf", nil},

+ {"-Inf", "-Inf", nil},

+ {"+INF", "+Inf", nil},

// largest float64

{"1.7976931348623157e308", "1.7976931348623157e+308", nil},

{"-1.7976931348623157e308", "-1.7976931348623157e+308", nil},

« no previous file with comments | « src/pkg/strconv/atof.go ('k') | no next file » | no next file with comments »