Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 335410043: Issue 3208: compressed MMRs choose correct glyphs

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by Malte Meyn
Modified:
1 year, 10 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3208: compressed MMRs choose correct glyphs usable-duration-logs now affects only the choice of glyph for the representation of a single measure. For multiple measures, glyphs for longer rests up to maxima are used. This is a second attempt to make it work and has little to do with my first attempt at https://codereview.appspot.com/333340043 Therefore I created a new Rietveld issue. Also the vertical positioning of half and shorter rest glyphs in MMRs now is handled correctly. BUT: this breaks make check because of a different positioning of breve rests in TabStaffs. For details see discussion below.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -58 lines) Patch
M lily/include/multi-measure-rest.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/multi-measure-rest.cc View 4 chunks +29 lines, -57 lines 1 comment Download

Messages

Total messages: 1
Malte Meyn
1 year, 10 months ago (2018-01-13 15:18:13 UTC) #1
https://codereview.appspot.com/335410043/diff/1/lily/multi-measure-rest.cc
File lily/multi-measure-rest.cc (left):

https://codereview.appspot.com/335410043/diff/1/lily/multi-measure-rest.cc#ol...
lily/multi-measure-rest.cc:291: // calculated from there.
This worked for maxima/longa/brevis/semibrevis rests. But half and shorter rests
cannot just hang from the staff line.

Have a look at the output of the following code:

\version "2.19.80"
\new TabStaff {
  \tabFullNotation
  \compressFullBarRests
  R\breve
  \time 4/2
  R\breve r\breve
}

It’s not consistent: in 4/4 the breve rests hangs, in 4/2 both r and R stand.
This needs a fix in rest.cc (or in the font?) so I thought it wouldn’t be too
bad to “break” it by making it more consistent while making shorter rests work
at the same time. Of course, that has to be fixed before this patch can be
applied.

I tried to separate the selection of rest glyphs and their positioning but I
didn’t succeed :/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b