Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(86)

Issue 335270043: parser.yy: reverse_music_list should heed PostEvents

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by dak
Modified:
1 year, 8 months ago
Reviewers:
Malte Meyn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

parser.yy: reverse_music_list should heed PostEvents Also contains commit: Add regtest for multiple post events from scheme

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
A input/regression/post-events-from-scheme.ly View 1 chunk +11 lines, -0 lines 2 comments Download
M lily/parser.yy View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2
Malte Meyn
LGTM https://codereview.appspot.com/335270043/diff/1/input/regression/post-events-from-scheme.ly File input/regression/post-events-from-scheme.ly (right): https://codereview.appspot.com/335270043/diff/1/input/regression/post-events-from-scheme.ly#newcode11 input/regression/post-events-from-scheme.ly:11: { c1 ##{ -. -! #} } Of ...
1 year, 8 months ago (2018-01-04 10:31:49 UTC) #1
dak
1 year, 8 months ago (2018-01-04 11:06:38 UTC) #2
https://codereview.appspot.com/335270043/diff/1/input/regression/post-events-...
File input/regression/post-events-from-scheme.ly (right):

https://codereview.appspot.com/335270043/diff/1/input/regression/post-events-...
input/regression/post-events-from-scheme.ly:11: { c1 ##{ -. -! #} }
On 2018/01/04 10:31:49, Malte Meyn wrote:
> Of course it’s not necessary, but maybe this could be changed to c' instead of
> c.

Will do, but does not warrant another test upload.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b