Issue 33390043: Change setValueFn to not be a transform (now is responsible for updating the value). Also rename va…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 33390043: Change setValueFn to not be a transform (now is responsible for updating the value). Also rename va… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by rafaelw

Modified:
11 years, 4 months ago

Reviewers:
arv

Base URL:
https://github.com/Polymer/observe-js.git@master

Visibility:
Public.

More Reviews

Description

Change setValueFn to not be a transform (now is responsible for updating the value). Also rename valueFn to transformFn. R=arv BUG= Committed: https://github.com/Polymer/observe-js/commit/fbe86b9

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -24 lines)			Patch
	M	src/observe.js	View		8 chunks	+22 lines, -19 lines	0 comments	Download
	M	tests/test.js	View		3 chunks	+55 lines, -5 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as rfbe86b9 (presubmit successful).

11 years, 5 months ago (2013-11-26 23:00:43 UTC) #1

arv

11 years, 5 months ago (2013-11-27 14:35:41 UTC) #2

Message was sent while issue was closed.

LGTM

https://codereview.appspot.com/33390043/diff/1/tests/test.js
File tests/test.js (right):

https://codereview.appspot.com/33390043/diff/1/tests/test.js#newcode366
tests/test.js:366: obj.foo = 2*value;
ws

Expand All Messages | Collapse All Messages