Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3517)

Issue 333700043: Enable emoji keybinding in Wayland (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by fujiwara
Modified:
6 years, 2 months ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Enable emoji keybinding in Wayland XI2 keybinding does not work for the root window in Wayland because of a security issue maybe. Now I think to move the keybinding in ibus-extension-gtk3 to each IBusEngine. FIXME: Unfortunatelly gtk_get_current_event_time() cannot get time for the delayed DBus events and gtk_window_move() does not work for GtkDialog without a parent window in Wayland. R=Shawn.P.Huang@gmail.com Committed: c57b7c34d75871db172e023b0094b979000f62fc

Patch Set 1 #

Patch Set 2 : Forgot ibusaccelgroup.c #

Patch Set 3 : Fix duplicated contents in ibusaccelgroup.[c|h] #

Patch Set 4 : Updated with the latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+863 lines, -65 lines) Patch
M bus/engineproxy.c View 4 chunks +18 lines, -1 line 0 comments Download
M bus/ibusimpl.c View 7 chunks +40 lines, -7 lines 0 comments Download
M bus/inputcontext.c View 4 chunks +28 lines, -1 line 0 comments Download
M src/Makefile.am View 2 chunks +2 lines, -0 lines 0 comments Download
M src/ibus.h View 1 chunk +1 line, -0 lines 0 comments Download
A src/ibusaccelgroup.h View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
A src/ibusaccelgroup.c View 1 2 1 chunk +529 lines, -0 lines 0 comments Download
M src/ibusengine.c View 11 chunks +174 lines, -5 lines 0 comments Download
M ui/gtk3/emojier.vala View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gtk3/extension.vala View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gtk3/panelbinding.vala View 6 chunks +16 lines, -49 lines 0 comments Download

Messages

Total messages: 3
fujiwara
6 years, 2 months ago (2018-02-23 14:21:01 UTC) #1
Peng
On 2018/02/23 14:21:01, fujiwara wrote: lgtm
6 years, 2 months ago (2018-02-23 16:12:11 UTC) #2
fujiwara
6 years, 2 months ago (2018-02-27 05:10:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
c57b7c34d75871db172e023b0094b979000f62fc (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b