Add harmonic by fret and by ratio to tablatures

Add harmonic by fret and by ratio to tablatures

Code written by Marc Hohl  (All the good stuff)
Code integrated by Carl Sorensen (Any mistakes are his responsibility)

[Carl, 2010-11-28 04:23:11]

I've taken Marc's harmonic.ly and moved the scheme functions into
scm/tablature.scm, the music functions into ly/engraver-init.ly, and the test
music into input/regression/tablature-harmonic-functions.ly.

I've also added docstrings for the functions that are called by the music
functions, since they need to be define-public as they are called from a ly
file.

I've removed the parenthesize functions from scm/tablature.scm, since the
parenthesizing is handled in tab-note-head::print.

Please review, and thanks, 

Carl

[marc, 2010-11-28 09:22:38]

Am 28.11.2010 05:23, schrieb Carl.D.Sorensen@gmail.com:
> Reviewers: marc, p.l.schmidt_gmx.de,
>
> Message:
> I've taken Marc's harmonic.ly and moved the scheme functions into
> scm/tablature.scm, the music functions into ly/engraver-init.ly, and the
> test music into input/regression/tablature-harmonic-functions.ly.
>
Wow, I am impressed! I was busy recently and planned to contribute the
harmonics stuff within the next days (or weeks, but at least before 
X-mas ;-)
and now you have done it already - thanks a lot!
> I've also added docstrings for the functions that are called by the
> music functions, since they need to be define-public as they are called
> from a ly file.
@Patrick: you offered your help for documenting the harmonic stuff once 
it is
included - is this offer still valid? ;-) If not, give me a ping, then 
I'll try to do this.
>
> I've removed the parenthesize functions from scm/tablature.scm, since
> the parenthesizing is handled in tab-note-head::print.
Looks much clearer now to me.
>
> Please review,
LGTM!
> and thanks,
Thanks to you!

Regards,

Marc

[pls, 2010-11-28 09:42:42]

Am 28.11.2010 um 10:22 schrieb Marc Hohl:

> Am 28.11.2010 05:23, schrieb Carl.D.Sorensen@gmail.com:
>> Reviewers: marc, p.l.schmidt_gmx.de,
>>
>> Message:
>> I've taken Marc's harmonic.ly and moved the scheme functions into
>> scm/tablature.scm, the music functions into ly/engraver-init.ly,  
>> and the
>> test music into input/regression/tablature-harmonic-functions.ly.
>>
> Wow, I am impressed! I was busy recently and planned to contribute the
> harmonics stuff within the next days (or weeks, but at least before  
> X-mas ;-)
> and now you have done it already - thanks a lot!
>> I've also added docstrings for the functions that are called by the
>> music functions, since they need to be define-public as they are  
>> called
>> from a ly file.
> @Patrick: you offered your help for documenting the harmonic stuff  
> once it is
> included - is this offer still valid? ;-) If not, give me a ping,  
> then I'll try to do this.
Yes, sure it's still valid. I might have to wait for the official  
release of 2.13.41, as I'm still struggling with my virtual machine.  
Yesterday I managed to build LilyPond but today the process aborted  
when I tried to update the source code...

Thanks very much!

patrick
>>
>> I've removed the parenthesize functions from scm/tablature.scm, since
>> the parenthesizing is handled in tab-note-head::print.
> Looks much clearer now to me.
>>
>> Please review,
> LGTM!
>> and thanks,
> Thanks to you!
>
> Regards,
>
> Marc
>

[Carl, 2010-11-28 14:07:07]

I forgot to mention that this patch applies on top of 

http://codereview.appspot.com/2723043/

Thanks,

Carl

[Carl, 2010-12-03 19:03:56]

This code has now been integrated in the tab-tie-follow-engraver changes, due to
my mistakes in git.

Please see http://codereview.appspot.com/2723043/

Thanks,

Carl