Issue 3321041: Add function comments to bus/inputcontext.[ch] and bus/engineproxy.[ch]

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3321041: Add function comments to bus/inputcontext.[ch] and bus/engineproxy.[ch] (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by Yusuke Sato

Modified:
15 years, 3 months ago

Reviewers:
shawn.p.huang, Peng Huang

CC:
satorux

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Add function comments to bus/inputcontext.[ch] and bus/engineproxy.[ch]. Removed a temporary hack for PREEDIT_CONDITION by adding bus_ibus_impl_is_embed_preedit_text function to ibusimpl.c. BUG=none TEST=manually

Patch Set 1 #

Total comments: 1

Patch Set 2 : review fix #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+576 lines, -75 lines)			Patch
M	bus/engineproxy.h	View		1 chunk	+118 lines, -0 lines	0 comments	Download
M	bus/engineproxy.c	View	1	15 chunks	+45 lines, -6 lines	0 comments	Download
M	bus/ibusimpl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	bus/ibusimpl.c	View		3 chunks	+11 lines, -3 lines	0 comments	Download
M	bus/inputcontext.h	View		2 chunks	+119 lines, -0 lines	0 comments	Download
M	bus/inputcontext.c	View		62 chunks	+281 lines, -66 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

LGTM. Thanks. http://codereview.appspot.com/3321041/diff/1/bus/engineproxy.c File bus/engineproxy.c (right): http://codereview.appspot.com/3321041/diff/1/bus/engineproxy.c#newcode419 bus/engineproxy.c:419: /* The list of null-ary D-Bus signals. ...

15 years, 3 months ago (2010-11-25 07:48:58 UTC) #2

Yusuke Sato

15 years, 3 months ago (2010-11-25 07:54:28 UTC) #3

I meant to say "signals without arguments."
http://en.wikipedia.org/wiki/Arity#Nullary

maybe I should have removed the '-'. Fixed.

On 2010/11/25 07:48:58, Shawn.P.Huang wrote:
> LGTM. Thanks.
> 
> http://codereview.appspot.com/3321041/diff/1/bus/engineproxy.c
> File bus/engineproxy.c (right):
> 
> http://codereview.appspot.com/3321041/diff/1/bus/engineproxy.c#newcode419
> bus/engineproxy.c:419: /* The list of null-ary D-Bus signals. */
> What is null-ary?

Expand All Messages | Collapse All Messages