Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(913)

Issue 332090043: Update EventChord to include a ChordSemantics event entry which captures input semantic information…

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by chazwins6
Modified:
6 years, 5 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Update EventChord to include a ChordSemantics event entry which captures input semantic information from chord mode and uses it to create chord names. Without these semantics, naming chords based only on their notes results in ambiguous naming: Example: Cm7 no root and Eb both have the exact same notes, and so there is no way to differentiate between them, unless we capture the data from chord mode: { cm:7.1 } as opposed to { eb }

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -362 lines) Patch
M Documentation/ca/web.texi View 1 chunk +1 line, -3 lines 0 comments Download
M Documentation/ca/web/community.itexi View 1 chunk +0 lines, -20 lines 0 comments Download
M Documentation/contributor/release-work.itexi View 1 chunk +0 lines, -4 lines 0 comments Download
M Documentation/cs/web/community.itexi View 1 chunk +0 lines, -17 lines 0 comments Download
M Documentation/de/web.texi View 1 chunk +1 line, -4 lines 0 comments Download
M Documentation/de/web/community.itexi View 1 chunk +0 lines, -18 lines 0 comments Download
M Documentation/es/web.texi View 1 chunk +1 line, -3 lines 0 comments Download
M Documentation/es/web/community.itexi View 1 chunk +0 lines, -18 lines 0 comments Download
M Documentation/fr/web.texi View 1 chunk +1 line, -4 lines 0 comments Download
M Documentation/fr/web/community.itexi View 1 chunk +0 lines, -26 lines 0 comments Download
M Documentation/hu/web/community.itexi View 1 chunk +3 lines, -19 lines 0 comments Download
M Documentation/it/web.texi View 1 chunk +1 line, -4 lines 0 comments Download
M Documentation/it/web/community.itexi View 1 chunk +0 lines, -16 lines 0 comments Download
M Documentation/ja/web.texi View 1 chunk +1 line, -4 lines 0 comments Download
M Documentation/ja/web/community.itexi View 1 chunk +0 lines, -18 lines 0 comments Download
M Documentation/notation/chords.itely View 3 chunks +32 lines, -5 lines 0 comments Download
M Documentation/notation/input.itely View 2 chunks +1 line, -5 lines 0 comments Download
M Documentation/web.texi View 1 chunk +1 line, -4 lines 0 comments Download
M Documentation/web/community.itexi View 2 chunks +0 lines, -19 lines 0 comments Download
M Documentation/zh/web/community.itexi View 1 chunk +0 lines, -18 lines 0 comments Download
A README.md View 1 chunk +7 lines, -0 lines 0 comments Download
M input/regression/chord-name-exceptions.ly View 2 chunks +5 lines, -4 lines 0 comments Download
A input/regression/chord-semantics-name-exceptions.ly View 1 chunk +27 lines, -0 lines 0 comments Download
A input/regression/chordtest-exceptions.ly View 1 chunk +30 lines, -0 lines 0 comments Download
A input/regression/parenthesize-laissezvibrer.ly View 1 chunk +10 lines, -0 lines 0 comments Download
M lily/chord-name-engraver.cc View 6 chunks +31 lines, -1 line 0 comments Download
A + lily/include/laissez-vibrer-engraver.hh View 2 chunks +19 lines, -15 lines 0 comments Download
M lily/laissez-vibrer-engraver.cc View 4 chunks +23 lines, -17 lines 0 comments Download
M lily/repeat-tie-engraver.cc View 2 chunks +18 lines, -48 lines 0 comments Download
M ly/chord-modifiers-init.ly View 1 chunk +2 lines, -0 lines 0 comments Download
M python/convertrules.py View 6 chunks +19 lines, -15 lines 0 comments Download
M scm/chord-entry.scm View 10 chunks +79 lines, -27 lines 0 comments Download
M scm/chord-ignatzek-names.scm View 2 chunks +46 lines, -4 lines 0 comments Download
M scm/chord-name.scm View 1 chunk +15 lines, -0 lines 0 comments Download
M scm/define-context-properties.scm View 2 chunks +3 lines, -1 line 0 comments Download
M scm/define-event-classes.scm View 1 chunk +2 lines, -1 line 0 comments Download
M scm/define-music-types.scm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1
pkx166h
6 years, 5 months ago (2017-11-02 16:37:29 UTC) #1
Charles I posted a comment on the LilyPond Tracker issue that was created for
this.

https://sourceforge.net/p/testlilyissues/issues/5224/

I'll past it here:

I don't understand the reason for the dozens of files that are changed in your
patch. Why you also have added a 'README.md' file (we don't tend to do that),
the documentation files that have changed seem to contain diffs that have
nothing at all to do with the description of your patch at all.

I wonder if you have made a mistake here and not rebased your changes against
current master or are basing it off some other branch?

I cannot test the patch as it is at the moment. Sorry.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b