Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(47)

Issue 331650043: Issue 2199: align outside-staff grobs vertically in staff groups (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Dan Eble
Modified:
1 year, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 2199: align outside-staff grobs vertically in staff groups In any context in which a Vertical_align_engraver creates a StaffGrouper, it also sees to it that all outside-staff grobs created in the immediate context become y-axis children of the StaffGrouper. Any such grobs which are later processed by the after-line-breaking callback ly:side-position-interface::move_to_extremal_staff are moved to the extremal staff of the group, not of the entire system.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -36 lines) Patch
A input/regression/bar-number-staff-group-context.ly View 1 chunk +44 lines, -0 lines 0 comments Download
A input/regression/metronome-marking-staff-group-context.ly View 1 chunk +35 lines, -0 lines 0 comments Download
M input/regression/rehearsal-mark-align-staff-context.ly View 1 chunk +1 line, -1 line 0 comments Download
A input/regression/rehearsal-mark-align-staff-group-context.ly View 1 chunk +54 lines, -0 lines 0 comments Download
M lily/include/staff-grouper-interface.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/system.hh View 1 chunk +0 lines, -1 line 0 comments Download
M lily/side-position-interface.cc View 2 chunks +21 lines, -9 lines 0 comments Download
M lily/staff-grouper-interface.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M lily/system.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M lily/vertical-align-engraver.cc View 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Dan Eble
1 year, 6 months ago (2018-02-25 03:17:37 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b