Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1608)

Issue 33084: [issue1580] Use shorter float repr when possible (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by dickinsm
Modified:
9 years, 5 months ago
Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Include extra files dtoa.c, dtoa.h and formatfloat_testcases.txt #

Total comments: 14

Patch Set 3 : Continued work on py3k-short-float-repr branch #

Total comments: 4

Patch Set 4 : New merge candidate: fix compiler warnings, universal build support #

Patch Set 5 : Include fallback code; fixed SSE2 detection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5304 lines, -844 lines) Patch
M Doc/library/sys.rst View 1 chunk +13 lines, -0 lines 0 comments Download
M Doc/license.rst View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download
M Include/Python.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Include/bytesobject.h View 3 4 1 chunk +12 lines, -14 lines 0 comments Download
A Include/dtoa.h View 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M Include/pymacconfig.h View 4 2 chunks +6 lines, -0 lines 0 comments Download
M Include/pymath.h View 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M Include/pyport.h View 3 4 1 chunk +47 lines, -0 lines 0 comments Download
M Include/pystrtod.h View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
M Include/unicodeobject.h View 3 4 1 chunk +12 lines, -14 lines 0 comments Download
A Lib/test/formatfloat_testcases.txt View 2 3 4 1 chunk +354 lines, -0 lines 0 comments Download
M Lib/test/test_float.py View 1 2 3 4 4 chunks +76 lines, -0 lines 0 comments Download
M Lib/test/test_format.py View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M Lib/test/test_types.py View 1 2 3 4 4 chunks +48 lines, -1 line 0 comments Download
M Makefile.pre.in View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M Misc/ACKS View 1 chunk +1 line, -0 lines 0 comments Download
M Modules/_pickle.c View 1 2 3 4 1 chunk +23 lines, -8 lines 0 comments Download
M Objects/bytesobject.c View 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Objects/complexobject.c View 1 2 3 4 2 chunks +97 lines, -70 lines 0 comments Download
M Objects/floatobject.c View 1 2 3 4 7 chunks +31 lines, -114 lines 0 comments Download
M Objects/stringlib/formatter.h View 1 2 3 4 21 chunks +411 lines, -299 lines 0 comments Download
M Objects/stringlib/localeutil.h View 3 4 1 chunk +151 lines, -104 lines 0 comments Download
M Objects/unicodeobject.c View 1 2 3 4 4 chunks +33 lines, -137 lines 0 comments Download
M PC/pyconfig.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M PCbuild/pythoncore.vcproj View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
A Python/dtoa.c View 2 3 4 1 chunk +2646 lines, -0 lines 0 comments Download
M Python/marshal.c View 1 2 3 4 2 chunks +18 lines, -8 lines 0 comments Download
M Python/pymath.c View 3 4 1 chunk +22 lines, -0 lines 0 comments Download
M Python/pystrtod.c View 1 2 3 4 10 chunks +540 lines, -56 lines 0 comments Download
M Python/sysmodule.c View 2 chunks +10 lines, -0 lines 0 comments Download
M configure View 1 2 3 4 5 chunks +460 lines, -12 lines 0 comments Download
M configure.in View 1 2 3 4 3 chunks +181 lines, -7 lines 0 comments Download
M pyconfig.h.in View 1 2 3 4 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Nick Coghlan
I didn't actually dig into the actual number crunching code all that much - that ...
10 years, 4 months ago (2009-04-09 10:52:04 UTC) #1
ericvsmith
Thanks for the comments, Nick. I've answered the few that apply to me, Mark can ...
10 years, 4 months ago (2009-04-09 11:44:20 UTC) #2
ericvsmith
Also a good idea. I'll check both of these in momentarily, once the tests pass. ...
10 years, 4 months ago (2009-04-09 11:49:00 UTC) #3
ericvsmith
http://codereview.appspot.com/33084/diff/1001/47 File Python/marshal.c (right): http://codereview.appspot.com/33084/diff/1001/47#newcode241 Line 241: if (!buf) A known post-merge task is to ...
10 years, 4 months ago (2009-04-09 12:50:33 UTC) #4
dickinsm
http://codereview.appspot.com/33084/diff/1001/62 File Lib/test/test_float.py (right): http://codereview.appspot.com/33084/diff/1001/62#newcode14 Line 14: #locate file with float format test values On ...
10 years, 4 months ago (2009-04-12 10:03:25 UTC) #5
Benjamin
I didn't look in detail, but here are my nits. http://codereview.appspot.com/33084/diff/3001/3028 File Makefile.pre.in (right): http://codereview.appspot.com/33084/diff/3001/3028#newcode604 ...
10 years, 4 months ago (2009-04-14 00:42:20 UTC) #6
dickinsm
http://codereview.appspot.com/33084/diff/3001/3028 File Makefile.pre.in (right): http://codereview.appspot.com/33084/diff/3001/3028#newcode604 Line 604: PYTHON_HEADERS= \ On 2009/04/14 00:42:20, Benjamin wrote: > ...
10 years, 4 months ago (2009-04-14 08:04:06 UTC) #7
ericvsmith
10 years, 4 months ago (2009-04-14 22:50:47 UTC) #8
http://codereview.appspot.com/33084/diff/1001/63
File Lib/test/test_types.py (right):

http://codereview.appspot.com/33084/diff/1001/63#newcode471
Line 471: #  after the py3k-short-float-repr merge
I've checked this in. It will be part of the merge to py3k. You can look at the
latest set of diffs to see it implemented.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b