code review 3308041: runtime: parallel definitions in Go for all C structs.

runtime: parallel definitions in Go for all C structs.

[lvd, 2010-11-30 15:48:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change.

[rsc1, 2010-11-30 15:57:15]

please undo the unnecessary changes.
please add a TODO(lvd): automate conversion
to all the _defs.go files and the comments in
the C files that say things have to be in sync.
i think having a 6c -g would work reasonably well.

http://codereview.appspot.com/3308041/diff/12001/src/pkg/runtime/iface.c
File src/pkg/runtime/iface.c (right):

http://codereview.appspot.com/3308041/diff/12001/src/pkg/runtime/iface.c#newc...
src/pkg/runtime/iface.c:22: * layout of Itable known to compilers
gratuitous name change

http://codereview.appspot.com/3308041/diff/12001/src/pkg/runtime/type.h
File src/pkg/runtime/type.h (right):

http://codereview.appspot.com/3308041/diff/12001/src/pkg/runtime/type.h#newco...
src/pkg/runtime/type.h:89: struct SliceType
gratuitous code movement

[rsc1, 2010-11-30 17:20:44]

LGTM

[lvd, 2010-11-30 17:21:33]

*** Submitted as http://code.google.com/p/go/source/detail?r=3e7a6a3c7e33 ***

runtime: parallel definitions in Go for all C structs.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3308041