Issue 33055: Fix #743: reinstate warning for unterminated span dynamics.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 33055: Fix #743: reinstate warning for unterminated span dynamics. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 1 month ago by Neil Puttock

Modified:
15 years, 8 months ago

Reviewers:
Reinhold

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix #743: reinstate warning for unterminated span dynamics.

Patch Set 1 #

Created: 16 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -16 lines)			Patch
	M	lily/new-dynamic-engraver.cc	View		5 chunks	+35 lines, -16 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Reinhold

I can't really judge the internals of the patch. But at least I don't see ...

15 years, 8 months ago (2009-09-01 12:04:52 UTC) #1

Neil Puttock

15 years, 8 months ago (2009-09-06 21:14:52 UTC) #2

On 2009/09/01 12:04:52, Reinhold wrote:
> I can't really judge the internals of the patch. But at least I don't see any
> obvious problem.

It should be harmless, since it's basically the same code lifted from
dynamic-engraver.cc with a slight refinement for the warning message.

> On the other hand, I would really like this to be included, as that issue has
> bitten me quite a few times while preparing ~50 small excerpts of Dvorak's
Cello
> concerto for a thesis...

OK, I'll add a regression test and rebase the code.

Regards,
Neil

Expand All Messages | Collapse All Messages