Issue 33053: Fix signed proxied content requests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 33053: Fix signed proxied content requests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years ago by awiner

Modified:
16 years, 9 months ago

Reviewers:

Base URL:
https://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: 17 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -4 lines)			Patch
M	java/common/conf/shindig.properties	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthArguments.java	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java	View	2 chunks	+6 lines, -0 lines	3 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/render/ProxyRenderer.java	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/OAuthRequestTest.java	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	javascript/samplecontainer/samplecontainer.js	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

vincent.siveton

shindig.signing.key-file should not include your user's file

17 years ago (2009-04-02 22:33:26 UTC) #2

beaton

LGTM. http://codereview.appspot.com/33053/diff/1/5 File java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java (right): http://codereview.appspot.com/33053/diff/1/5#newcode90 Line 90: protected static final String OPENSOCIAL_PROXIED_CONTENT = "opensocial_proxied_content"; ...

17 years ago (2009-04-02 22:42:22 UTC) #3

louiscryan

17 years ago (2009-04-02 23:13:11 UTC) #4

http://codereview.appspot.com/33053/diff/1/5
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
(right):

http://codereview.appspot.com/33053/diff/1/5#newcode90
Line 90: protected static final String OPENSOCIAL_PROXIED_CONTENT =
"opensocial_proxied_content";
On 2009/04/02 22:42:22, beaton wrote:
> This should go in
>
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/common/src/main/jav...

Seems more consistent to keep it here. Its not an OAuth param.

Expand All Messages | Collapse All Messages