ui/gtk3: Fix PropertyPanel position in workarea

ui/gtk3: Fix PropertyPanel position in workarea

gdk_screen_get_monitor_workarea() no longer return the correct area
from "_NET_WORKAREA" atom in GTK 3.22 and now use
gdk_monitor_get_workarea() instead.

Use gdk_seat_grab() instead of deprecated gdk_device_grab().

Use gtk_menu_popup_at_rect() instead of deprecated gtk_menu_popup() and
generate a new foreign GdkWindow with mouse cursor for the Qt Window.

Also fixed some deprecated APIs.

R=Shawn.P.Huang@gmail.com

Committed: 0632cbbbb573749bbca96a416fde1490810e52d2

[Peng, 2017-09-11 13:44:49]

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/candidatepanel.vala
File ui/gtk3/candidatepanel.vala (right):

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/candidatepanel.vala#n...
ui/gtk3/candidatepanel.vala:312: #if VALA_0_34
Is it possible put common code in method instead of having #if everywhere?

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/indicator.vala
File ui/gtk3/indicator.vala (right):

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/indicator.vala#newcod...
ui/gtk3/indicator.vala:516: #if VALA_0_34
#if !VALA...?

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/keybindingmanager.vala
File ui/gtk3/keybindingmanager.vala (left):

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/keybindingmanager.val...
ui/gtk3/keybindingmanager.vala:21: public static const uint MODIFIER_FILTER =
why remove static?

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/panel.vala#newcode299
ui/gtk3/panel.vala:299: #if VALA_0_34
Is it possible ot put the common code in a method to avoid #if everywhere?

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/propertypanel.vala
File ui/gtk3/propertypanel.vala (right):

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/propertypanel.vala#ne...
ui/gtk3/propertypanel.vala:550: #if VALA_0_34
#if !...?

[fujiwara, 2017-09-12 12:16:54]

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/candidatepanel.vala
File ui/gtk3/candidatepanel.vala (right):

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/candidatepanel.vala#n...
ui/gtk3/candidatepanel.vala:312: #if VALA_0_34
On 2017/09/11 13:44:49, Peng wrote:
> Is it possible put common code in method instead of having #if everywhere?

Done.

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/indicator.vala
File ui/gtk3/indicator.vala (right):

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/indicator.vala#newcod...
ui/gtk3/indicator.vala:516: #if VALA_0_34
On 2017/09/11 13:44:49, Peng wrote:
> #if !VALA...?

Done.

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/keybindingmanager.vala
File ui/gtk3/keybindingmanager.vala (left):

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/keybindingmanager.val...
ui/gtk3/keybindingmanager.vala:21: public static const uint MODIFIER_FILTER =
On 2017/09/11 13:44:49, Peng wrote:
> why remove static?

keybindingmanager.vala:21.5-36.36: warning: the modifier `static' is not
applicable to constants

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/panel.vala#newcode299
ui/gtk3/panel.vala:299: #if VALA_0_34
On 2017/09/11 13:44:49, Peng wrote:
> Is it possible ot put the common code in a method to avoid #if everywhere?

Done.

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/propertypanel.vala
File ui/gtk3/propertypanel.vala (right):

https://codereview.appspot.com/330190043/diff/1/ui/gtk3/propertypanel.vala#ne...
ui/gtk3/propertypanel.vala:550: #if VALA_0_34
On 2017/09/11 13:44:49, Peng wrote:
> #if !...?

Done.

[Peng, 2017-09-13 00:10:41]

On 2017/09/12 12:16:54, fujiwara wrote:
> https://codereview.appspot.com/330190043/diff/1/ui/gtk3/candidatepanel.vala
> File ui/gtk3/candidatepanel.vala (right):
> 
>
https://codereview.appspot.com/330190043/diff/1/ui/gtk3/candidatepanel.vala#n...
> ui/gtk3/candidatepanel.vala:312: #if VALA_0_34
> On 2017/09/11 13:44:49, Peng wrote:
> > Is it possible put common code in method instead of having #if everywhere?
> 
> Done.
> 
> https://codereview.appspot.com/330190043/diff/1/ui/gtk3/indicator.vala
> File ui/gtk3/indicator.vala (right):
> 
>
https://codereview.appspot.com/330190043/diff/1/ui/gtk3/indicator.vala#newcod...
> ui/gtk3/indicator.vala:516: #if VALA_0_34
> On 2017/09/11 13:44:49, Peng wrote:
> > #if !VALA...?
> 
> Done.
> 
> https://codereview.appspot.com/330190043/diff/1/ui/gtk3/keybindingmanager.vala
> File ui/gtk3/keybindingmanager.vala (left):
> 
>
https://codereview.appspot.com/330190043/diff/1/ui/gtk3/keybindingmanager.val...
> ui/gtk3/keybindingmanager.vala:21: public static const uint MODIFIER_FILTER =
> On 2017/09/11 13:44:49, Peng wrote:
> > why remove static?
> 
> keybindingmanager.vala:21.5-36.36: warning: the modifier `static' is not
> applicable to constants
> 
> https://codereview.appspot.com/330190043/diff/1/ui/gtk3/panel.vala
> File ui/gtk3/panel.vala (right):
> 
> https://codereview.appspot.com/330190043/diff/1/ui/gtk3/panel.vala#newcode299
> ui/gtk3/panel.vala:299: #if VALA_0_34
> On 2017/09/11 13:44:49, Peng wrote:
> > Is it possible ot put the common code in a method to avoid #if everywhere?
> 
> Done.
> 
> https://codereview.appspot.com/330190043/diff/1/ui/gtk3/propertypanel.vala
> File ui/gtk3/propertypanel.vala (right):
> 
>
https://codereview.appspot.com/330190043/diff/1/ui/gtk3/propertypanel.vala#ne...
> ui/gtk3/propertypanel.vala:550: #if VALA_0_34
> On 2017/09/11 13:44:49, Peng wrote:
> > #if !...?
> 
> Done.

Lgtm

[fujiwara, 2017-09-13 09:15:19]

Committed patchset #3 (id:40001) manually as
0632cbbbb573749bbca96a416fde1490810e52d2 (presubmit successful).