Issue 328410043: Support the portal in the gtk im modules

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 328410043: Support the portal in the gtk im modules (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 8 months ago by fujiwara

Modified:
6 years, 7 months ago

Reviewers:
shawn.p.huang, Peng

CC:
alexl_redhat.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Support the portal in the gtk im modules This adds a new way to create an IbusBus, ibus_bus_new_async_client(). This returns an object that is not guarantee to handle any calls that are not needed by a client, meaning CreateInputContext and handling the input context. If you are running in a flatpak, or if IBUS_USE_PORTAL is set, then instead of talking to the regular ibus bus we connect to org.freedesktop.portal.IBus on the session bus and use the limited org.freedesktop.IBus.Portal interface instead of the org.freedesktop.IBus interface. This allows flatpaks (or other sandbox systems) to safely use dbus clients (apps). BUG=https://github.com/flatpak/flatpak/issues/675 Committed: 35ce62474fa97a5460d72c360943700a413a07ae

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+256 lines, -31 lines)			Patch
M	client/gtk2/ibusimcontext.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ibusbus.h	View	2 chunks	+23 lines, -0 lines	0 comments	Download
M	src/ibusbus.c	View	24 chunks	+221 lines, -27 lines	0 comments	Download
M	src/ibusinputcontext.c	View	2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

This patch is the second of two which works in Flatpak. Alexander Larsson provided the ...

6 years, 8 months ago (2017-08-30 02:49:33 UTC) #1

fujiwara

6 years, 7 months ago (2017-08-31 03:03:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
35ce62474fa97a5460d72c360943700a413a07ae (presubmit successful).

Expand All Messages | Collapse All Messages