Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(701)

Issue 328250043: client/gtk2: include the scaling factor (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by fujiwara
Modified:
6 years, 7 months ago
Reviewers:
shawn.p.huang, Peng
CC:
sfanxiang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

client/gtk2: include the scaling factor Scaling factor, which exists for HiDPI displays, needs to be included in the calculation of cursor location. This does not affect devices without a HiDPI display. Candidate windows would be misplaced to smaller coordinates without this patch. BUG=https://github.com/ibus/ibus/issues/1806 Committed: 6a3301db85e77e0652f7e00894cce493b6a942f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M client/gtk2/ibusimcontext.c View 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 3
fujiwara
6 years, 7 months ago (2017-08-09 07:00:51 UTC) #1
Peng
lgtm
6 years, 7 months ago (2017-08-09 13:31:08 UTC) #2
fujiwara
6 years, 7 months ago (2017-08-10 02:25:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a3301db85e77e0652f7e00894cce493b6a942f6 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b