Issue 328250043: client/gtk2: include the scaling factor

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 328250043: client/gtk2: include the scaling factor (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 3 months ago by fujiwara

Modified:
7 years, 3 months ago

Reviewers:
shawn.p.huang, Peng

CC:
sfanxiang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

client/gtk2: include the scaling factor Scaling factor, which exists for HiDPI displays, needs to be included in the calculation of cursor location. This does not affect devices without a HiDPI display. Candidate windows would be misplaced to smaller coordinates without this patch. BUG=https://github.com/ibus/ibus/issues/1806 Committed: 6a3301db85e77e0652f7e00894cce493b6a942f6

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
	M	client/gtk2/ibusimcontext.c	View		3 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

7 years, 3 months ago (2017-08-10 02:25:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6a3301db85e77e0652f7e00894cce493b6a942f6 (presubmit successful).

Expand All Messages | Collapse All Messages