Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1750)

Issue 327850043: NS-3 GSoC 2017 LTE CA handover milestone 1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by ilabdsf
Modified:
1 year, 12 months ago
Reviewers:
biljana.bojovic, Tom Henderson, zorazeali
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

NS-3 GSoC 2017 LTE CA handover milestone 1

Patch Set 1 #

Total comments: 14
Unified diffs Side-by-side diffs Delta from patch set Stats (+1051 lines, -366 lines) Patch
M src/lte/helper/cc-helper.cc View 2 chunks +7 lines, -4 lines 3 comments Download
M src/lte/helper/lte-helper.h View 6 chunks +25 lines, -21 lines 2 comments Download
M src/lte/helper/lte-helper.cc View 17 chunks +74 lines, -81 lines 0 comments Download
M src/lte/model/component-carrier-enb.h View 3 chunks +15 lines, -1 line 0 comments Download
M src/lte/model/component-carrier-enb.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M src/lte/model/lte-ccm-rrc-sap.h View 3 chunks +16 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-net-device.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-net-device.cc View 3 chunks +16 lines, -1 line 0 comments Download
M src/lte/model/lte-enb-rrc.h View 10 chunks +40 lines, -10 lines 1 comment Download
M src/lte/model/lte-enb-rrc.cc View 35 chunks +169 lines, -130 lines 2 comments Download
M src/lte/model/lte-rrc-header.cc View 17 chunks +29 lines, -9 lines 6 comments Download
M src/lte/model/lte-rrc-protocol-ideal.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/lte/model/lte-rrc-protocol-ideal.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/lte/model/lte-rrc-protocol-real.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/lte/model/lte-rrc-protocol-real.cc View 4 chunks +5 lines, -12 lines 0 comments Download
M src/lte/model/lte-rrc-sap.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/lte/model/lte-ue-rrc.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/lte/model/no-op-component-carrier-manager.cc View 5 chunks +10 lines, -10 lines 0 comments Download
A src/lte/test/lte-test-aggregation-throughput-scale.h View 1 chunk +70 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-aggregation-throughput-scale.cc View 1 chunk +168 lines, -0 lines 0 comments Download
M src/lte/test/lte-test-carrier-aggregation.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-secondary-cell-selection.h View 1 chunk +115 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-secondary-cell-selection.cc View 1 chunk +199 lines, -0 lines 0 comments Download
M src/lte/test/test-lte-handover-delay.cc View 8 chunks +47 lines, -75 lines 0 comments Download
M src/lte/wscript View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Biljana Bojović
Hi, please find my comments. I think that cc-helper function needs to be further improved. ...
2 years, 1 month ago (2017-06-27 17:13:50 UTC) #1
Tom Henderson
This looks good; I have one comment (request) and one question. request: We need the ...
2 years, 1 month ago (2017-06-29 15:46:30 UTC) #2
Biljana Bojović
I agree with Tom's request. Regarding the question, I think that there is basically nothing ...
2 years, 1 month ago (2017-06-30 11:38:25 UTC) #3
ilabdsf
https://codereview.appspot.com/327850043/diff/1/src/lte/helper/cc-helper.cc File src/lte/helper/cc-helper.cc (right): https://codereview.appspot.com/327850043/diff/1/src/lte/helper/cc-helper.cc#newcode178 src/lte/helper/cc-helper.cc:178: On 2017/06/27 17:13:50, Biljana Bojović wrote: > I agree ...
2 years, 1 month ago (2017-06-30 12:25:33 UTC) #4
zorazeali
https://codereview.appspot.com/327850043/diff/1/src/lte/helper/cc-helper.cc File src/lte/helper/cc-helper.cc (right): https://codereview.appspot.com/327850043/diff/1/src/lte/helper/cc-helper.cc#newcode179 src/lte/helper/cc-helper.cc:179: // One RB is 200 kHz wide, while increment ...
2 years, 1 month ago (2017-07-04 14:53:03 UTC) #5
Biljana Bojović
2 years, 1 month ago (2017-07-11 08:57:19 UTC) #6
Thanks Zoraze for sharing the formula. The formula that you shared could be
useful in a general case. However, the function in CcHelper had the original
idea to create equally spaced carriers. But, the function had a bug which was
spotted by Alexander (overlapping of contiguous bands). Alexander provided a
patch according to which the central frequencies are calculated correctly, and
additionally he added constraint to have 300KHz spacing.

It would be nice also to have the generic function that can create different
combinations of contiguous carriers of different bandwidths, but this was not
planned under this GSoC project plan and I think it will not be needed for tests
and examples of this GSoC project.


On 2017/07/04 14:53:03, zorazeali wrote:
> https://codereview.appspot.com/327850043/diff/1/src/lte/helper/cc-helper.cc
> File src/lte/helper/cc-helper.cc (right):
> 
>
https://codereview.appspot.com/327850043/diff/1/src/lte/helper/cc-helper.cc#n...
> src/lte/helper/cc-helper.cc:179: // One RB is 200 kHz wide, while increment by
1
> in corresponds to 100 kHz shift
> I think the other way to do this is by following the nominal channel spacing
> formula given by 3GPP. Following is my suggestion. 
> 
> Let us suppose bw_pCC and bw_sCC are the bandwidths of primary and secondary
> component carriers in MHz, e.g., if both bandwidths are 5000000 Hz following
> function will take CarrierAggregationChannelSpacing(5, 5)
> 
> double CarrierAggregationChannelSpacing(bw_pCC, bw_sCC)
> 
>  {
>     % Nominal channel spacing as defined in TS36.101 5.7.1A
> 
>     spacing = 1.0e6 * (floor((bw_pCC+bw_sCC-0.1*abs(bw_pCC-
>               bw_sCC))/0.6)*0.3);
>     return spacing;
>  }
> 
> Now we will find the carrier frequency and the EARFCN of secondary component
> carrier (Fc_sCC and dlEarfcn_sCC).
>     
> First we find the band number of primary component carrier to find the Fc_sCC
> and dlEarfcn_sCC with in the same band.
> 
>     bandNumber = GetDownlinkCarrierBand (dlEarfcn_pCC)
> 
>     fc_pCC=GetCarrierFrequency (uint32_t dlEarfcn_pCC)
>   
>     Fc_sCC= fc_pCC + spacing (Note: Here Fc_sCC would be in Hz)
> 
>    % Function to find the EARFCN from carrier frequency. Formula assumes
> frequencies in MHz so we do 
> 
>     Fc_sCC = Fc_sCC/1.0e6
> 
>     dlEarfcn_sCC = (Fc_sCC - g_eutraChannelNumbers[bandNumber].fDlLow + 0.1 *
> g_eutraChannelNumbers[bandNumber].nOffsDl)/0.1
> 
> 
> Now you have the correct Dl EARFCN number of the secondary component carrier
> whose carrier frequency spacing is multiple of 300 KHz. You 
> can generalize these functions to be used for both downlink and uplink.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b