Issue 327290043: client/gtk2: Do not send key events to GtkIMContextSimple

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 327290043: client/gtk2: Do not send key events to GtkIMContextSimple (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 2 months ago by fujiwara

Modified:
7 years, 2 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

client/gtk2: Do not send key events to GtkIMContextSimple GtkIMContextSimple binds Ctrl-Shift-u but IBus clients do not now. BUG=https://github.com/ibus/ibus/issues/1889 R=Shawn.P.Huang@gmail.com Committed: bbfb3d738b9d61d1eb0658a9ce56e3cd8c111ac4

Patch Set 1 #

Patch Set 2 : Updated with the latest master #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -25 lines)			Patch
M	client/gtk2/ibusimcontext.c	View	3 chunks	+39 lines, -2 lines	0 comments	Download
M	src/ibusenginesimple.h	View	3 chunks	+22 lines, -2 lines	0 comments	Download
M	src/ibusenginesimple.c	View	2 chunks	+2 lines, -21 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

7 years, 2 months ago (2017-09-06 05:08:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
bbfb3d738b9d61d1eb0658a9ce56e3cd8c111ac4 (presubmit successful).

Expand All Messages | Collapse All Messages