Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(139)

Issue 327150043: [plaso] Changed tests files to include multiple tags #1038 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by Joachim Metz
Modified:
7 years, 4 months ago
Reviewers:
jberggren, onager
CC:
romaing, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Changed tests files to include multiple tags #1038

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -136 lines) Patch
M config/tests/generate_test_files.sh View 2 chunks +13 lines, -2 lines 0 comments Download
M test_data/end_to_end/dynamic.log View 2 chunks +5 lines, -5 lines 0 comments Download
M test_data/end_to_end/json.log View 2 chunks +5 lines, -5 lines 0 comments Download
M test_data/end_to_end/json_line.log View 2 chunks +5 lines, -5 lines 0 comments Download
M test_data/end_to_end/l2tcsv.log View 2 chunks +4 lines, -4 lines 0 comments Download
M test_data/end_to_end/l2ttln.log View 1 chunk +4 lines, -4 lines 0 comments Download
M test_data/end_to_end/rawpy.log View 8 chunks +8 lines, -8 lines 0 comments Download
M test_data/end_to_end/tln.log View 1 chunk +4 lines, -4 lines 0 comments Download
M test_data/pinfo_test.json.plaso View 0 chunks +-1 lines, --1 lines 0 comments Download
M test_data/psort_test.json.plaso View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/cli/pinfo_tool.py View 8 chunks +99 lines, -97 lines 0 comments Download
M tests/storage/zip_file.py View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3
Joachim Metz
7 years, 4 months ago (2017-08-20 10:46:31 UTC) #1
onager
LGTM
7 years, 4 months ago (2017-08-21 08:29:19 UTC) #2
Joachim Metz
7 years, 4 months ago (2017-08-21 17:40:18 UTC) #3
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close tagging2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b