Issue 326520043: Remove duplicated entries in DNS cache plugin.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 326520043: Remove duplicated entries in DNS cache plugin. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 6 months ago by scudette

Modified:
8 years, 6 months ago

Reviewers:
amoser

CC:
rekall-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Remove duplicated entries in DNS cache plugin. Committed: 86b8437691653e9e4481a3b8999da0571867cef5

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -1 line)			Patch
M	rekall-core/rekall/plugins/windows/dns.py	View	1 chunk	+13 lines, -0 lines	1 comment	Download
M	rekall-core/rekall/plugins/yarascanner.py	View	1 chunk	+1 line, -1 line	0 comments	Download
A	rekall-core/resources/.gitignore	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

scudette

Committed patchset #1 (id:1) manually as 86b8437691653e9e4481a3b8999da0571867cef5 (presubmit successful).

8 years, 6 months ago (2017-09-22 17:40:23 UTC) #1

amoser

8 years, 6 months ago (2017-09-23 08:50:15 UTC) #2

Message was sent while issue was closed.

https://codereview.appspot.com/326520043/diff/1/rekall-core/rekall/plugins/wi...
File rekall-core/rekall/plugins/windows/dns.py (right):

https://codereview.appspot.com/326520043/diff/1/rekall-core/rekall/plugins/wi...
rekall-core/rekall/plugins/windows/dns.py:386: if entries.obj_offset in buckets:
This doesn't seem right, do you mean in entries?

Expand All Messages | Collapse All Messages