Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(476)

Issue 326350043: Initial version of ibus portal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by fujiwara
Modified:
6 years, 8 months ago
Reviewers:
shawn.p.huang, Peng
CC:
alexl_redhat.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Initial version of ibus portal This adds a dbus service called org.freedesktop.portal.IBus on the session bus. It is a very limited service that only implements CreateInputContext and the InputContext interface (and Service.Destroy for lifetime access). It uses gdbus code generation for demarshalling the method calls which means it will verify that all arguments have the right type. Additionally all method calls to the input context object have to be from the client that created it, so each client is isolated. BUG=https://github.com/flatpak/flatpak/issues/675 R=Shawn.P.Huang@gmail.com Committed: 203a3df5a239d644cf42b7bac03a268eb5babfc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+887 lines, -40 lines) Patch
M Makefile.am View 1 chunk +1 line, -0 lines 0 comments Download
M configure.ac View 3 chunks +4 lines, -1 line 0 comments Download
A + portal/Makefile.am View 4 chunks +35 lines, -39 lines 0 comments Download
A portal/org.freedesktop.IBus.Portal.xml View 1 chunk +132 lines, -0 lines 0 comments Download
A portal/org.freedesktop.portal.IBus.service.in View 1 chunk +3 lines, -0 lines 0 comments Download
A portal/portal.c View 1 chunk +698 lines, -0 lines 0 comments Download
M src/ibusshare.h View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3
fujiwara
This patch is the first of two which works in Flatpak sandboxes, makes ibus clients ...
6 years, 8 months ago (2017-08-28 12:45:36 UTC) #1
Peng
On 2017/08/28 12:45:36, fujiwara wrote: > This patch is the first of two which works ...
6 years, 8 months ago (2017-08-29 15:12:52 UTC) #2
fujiwara
6 years, 8 months ago (2017-08-30 02:38:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
203a3df5a239d644cf42b7bac03a268eb5babfc7 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b