Issue 325750043: ui/gtk3: Fix to focus Emojir when type Control-Shift-e twice

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 325750043: ui/gtk3: Fix to focus Emojir when type Control-Shift-e twice (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 1 month ago by fujiwara

Modified:
7 years, 1 month ago

Reviewers:
shawn.p.huang, Peng

CC:
Peng Wu, tiagomatos_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

ui/gtk3: Fix to focus Emojier when type Control-Shift-e twice Some window managers, e.g. MATE, GNOME, Plasma desktops, does not give the keyboard focus when Emojier is lauched twice with Ctrl-Shift-e via XIEvent, if present_with_time() is not applied. Also fix to type some of ASCII emoji annotations likes :D Also update ibus-emoji.7.in to describe Control-f,b,n,p BUG=https://mail.gnome.org/archives/gtk-devel-list/2017-May/msg00026.html Committed: 086fc542a7a9b1313198ae60355e711da05f5ed8

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -48 lines)			Patch
M	ui/gtk3/emojier.vala	View	9 chunks	+51 lines, -32 lines	0 comments	Download
M	ui/gtk3/emojierapp.vala	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	ui/gtk3/ibus-emoji.7.in	View	1 chunk	+15 lines, -8 lines	0 comments	Download
M	ui/gtk3/ibusemojidialog.h	View	3 chunks	+6 lines, -2 lines	0 comments	Download
M	ui/gtk3/panel.vala	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

7 years, 1 month ago (2017-05-15 04:32:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
086fc542a7a9b1313198ae60355e711da05f5ed8 (presubmit successful).

Expand All Messages | Collapse All Messages