Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 325042: Fix digits values, use a _constraints to check rate and factor (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 11 months ago by ced
Modified:
15 years, 11 months ago
Reviewers:
bch, timitos, yangoon1
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Use 12 decimal digits and update uom #

Patch Set 3 : Better way to select the more accurate field for computation #

Patch Set 4 : Fix select_accurate_field and add unittest #

Patch Set 5 : Add unittest #

Patch Set 6 : Add more unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -76 lines) Patch
M CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/test_product.py View 4 5 3 chunks +160 lines, -1 line 0 comments Download
M uom.py View 1 2 3 4 5 7 chunks +79 lines, -44 lines 0 comments Download
M uom.xml View 1 2 3 4 5 7 chunks +31 lines, -31 lines 0 comments Download

Messages

Total messages: 12
ced
15 years, 11 months ago (2010-03-09 12:33:01 UTC) #1
yangoon1
Did I misunderstand something? http://codereview.appspot.com/325042/diff/1/3 File uom.xml (right): http://codereview.appspot.com/325042/diff/1/3#newcode190 uom.xml:190: <field name="rate" eval="2.204624"/> 2,204623 directly ...
15 years, 11 months ago (2010-03-09 13:33:23 UTC) #2
ced
http://codereview.appspot.com/325042/diff/1/3 File uom.xml (right): http://codereview.appspot.com/325042/diff/1/3#newcode190 uom.xml:190: <field name="rate" eval="2.204624"/> On 2010/03/09 13:33:27, yangoon wrote: > ...
15 years, 11 months ago (2010-03-09 13:37:09 UTC) #3
timitos
http://codereview.appspot.com/325042/diff/1/2 File uom.py (right): http://codereview.appspot.com/325042/diff/1/2#newcode63 uom.py:63: 'delete it ortherwise you can deactivate it ' s/ortherwise/otherwise
15 years, 11 months ago (2010-03-09 14:06:26 UTC) #4
ced
15 years, 11 months ago (2010-03-09 14:39:45 UTC) #5
ced
http://codereview.appspot.com/325042/diff/1/2 File uom.py (right): http://codereview.appspot.com/325042/diff/1/2#newcode63 uom.py:63: 'delete it ortherwise you can deactivate it ' On ...
15 years, 11 months ago (2010-03-09 14:53:38 UTC) #6
ced
15 years, 11 months ago (2010-03-09 15:29:54 UTC) #7
ced
15 years, 11 months ago (2010-03-09 16:35:31 UTC) #8
yangoon1
[Tue Mar 09 19:57:09 2010] ERROR:convert:Error while parsing xml file: In tag record: model product.uom ...
15 years, 11 months ago (2010-03-09 19:07:37 UTC) #9
ced
On 2010/03/09 19:07:37, yangoon wrote: > NameError: name 'round' is not defined You must apply ...
15 years, 11 months ago (2010-03-09 20:30:22 UTC) #10
ced
15 years, 11 months ago (2010-03-10 09:40:22 UTC) #11
ced
15 years, 11 months ago (2010-03-10 18:55:49 UTC) #12

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b