Issue 324720043: Fix IBusEmojiDialog_1_0_gir_LIBS for --as-needed LDFLAGS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 324720043: Fix IBusEmojiDialog_1_0_gir_LIBS for --as-needed LDFLAGS (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 3 months ago by fujiwara

Modified:
7 years, 3 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fix IBusEmojiDialog_1_0_gir_LIBS for --as-needed LDFLAGS The order gets omitted libibus-1.0.la BUG=https://github.com/ibus/ibus/issues/1917 Committed: c3168d4701eb4e89094249abaa4f0f83ab24149b

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/gtk3/Makefile.am	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

On 2017/03/28 11:04:58, Peng wrote: > On 2017/03/28 09:31:21, fujiwara wrote: > > Sgtm Ltgm

7 years, 3 months ago (2017-03-28 11:05:08 UTC) #3

fujiwara

7 years, 3 months ago (2017-03-29 04:01:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c3168d4701eb4e89094249abaa4f0f83ab24149b (presubmit successful).

Expand All Messages | Collapse All Messages