Issue 323860043: Make all emoji dicts for fully qualified

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 323860043: Make all emoji dicts for fully qualified (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 5 months ago by fujiwara

Modified:
7 years, 5 months ago

Reviewers:
shawn.p.huang, penghuang

CC:
maiku.fabian

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Make all emoji dicts for fully qualified Currently only emoji-en.dict enables fully qualified since it imports emoji-test.txt and it causes to hardly compare emojis between emoji-en.dict and emoji-$lang.dict when m_show_emoji_variant is enabled. E.g. U+1F3CC-FE0F-200D-2642-FE0F Now emoji-$lang.dict also import emoji-test.txt and enables fully qualified. R=penghuang@google.com Committed: ad80999f5a10faee1a665a2232e1cf60be901cc8

Patch Set 1 #

Patch Set 2 : Fixed a typo. #

Patch Set 3 : Updated with the latest master #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -35 lines)			Patch
M	src/Makefile.am	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/emoji-parser.c	View	1	6 chunks	+150 lines, -17 lines	0 comments	Download
M	src/ibusemoji.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gtk3/emojier.vala	View	1 2	5 chunks	+17 lines, -17 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

7 years, 5 months ago (2017-05-29 03:03:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
ad80999f5a10faee1a665a2232e1cf60be901cc8 (presubmit successful).

Expand All Messages | Collapse All Messages