Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3643)

Issue 323720043: Move language setting from IBusEmojier to ibus-setup (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by fujiwara
Modified:
7 years, 3 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Move language setting from IBusEmojier to ibus-setup The language setting of emoji annotations now can be saved with ibus-setup. Implement `ibus emoji [--font|--lang|--help]` R=Shawn.P.Huang@gmail.com Committed: 0efb1c503d5901bbddcdb6fa73007b364ba4368d

Patch Set 1 #

Patch Set 2 : Fix a dynamic language setting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+671 lines, -270 lines) Patch
M data/ibus.schemas.in View 3 chunks +30 lines, -16 lines 0 comments Download
M setup/Makefile.am View 2 chunks +14 lines, -12 lines 0 comments Download
A setup/emojilang.py View 1 chunk +348 lines, -0 lines 0 comments Download
M setup/main.py View 6 chunks +30 lines, -11 lines 0 comments Download
M setup/setup.ui View 1 2 chunks +66 lines, -31 lines 0 comments Download
M tools/main.vala View 2 chunks +34 lines, -4 lines 0 comments Download
M ui/gtk3/emojier.vala View 1 45 chunks +113 lines, -182 lines 0 comments Download
M ui/gtk3/ibusemojidialog.h View 1 chunk +11 lines, -0 lines 0 comments Download
M ui/gtk3/panel.vala View 8 chunks +25 lines, -14 lines 0 comments Download

Messages

Total messages: 4
fujiwara
7 years, 3 months ago (2017-03-25 09:40:10 UTC) #1
Peng
On 2017/03/25 09:40:10, fujiwara wrote: lgtm
7 years, 3 months ago (2017-03-25 14:00:22 UTC) #2
Peng
On 2017/03/25 09:40:10, fujiwara wrote: lgtm
7 years, 3 months ago (2017-03-25 14:00:23 UTC) #3
fujiwara
7 years, 3 months ago (2017-03-27 06:12:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0efb1c503d5901bbddcdb6fa73007b364ba4368d (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b