Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(148)

Issue 323310043: ui/gtk3: Fix SEGV of IBusEmojier on de_DE.UTF-8 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by fujiwara
Modified:
6 years, 8 months ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ui/gtk3: Fix SEGV of IBusEmojier on de_DE.UTF-8 de's decimal_point is ',' instead of '.' and failed to load the CSS data in Gtk.CssProvider.load_from_data(), launched null window of emojis and finally caused a SEGV due to the null window. This also fixes some memory leaks. BUG=rhbz#1471079 Committed: bc0f91342c6f3a6e554493af9430d634d906ee19

Patch Set 1 #

Patch Set 2 : Updated with the latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M src/ibusemoji.c View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gtk3/emojier.vala View 6 chunks +26 lines, -7 lines 0 comments Download

Messages

Total messages: 3
fujiwara
6 years, 8 months ago (2017-07-20 11:49:33 UTC) #1
Peng
lgtm
6 years, 8 months ago (2017-07-25 02:16:20 UTC) #2
fujiwara
6 years, 8 months ago (2017-07-25 03:00:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bc0f91342c6f3a6e554493af9430d634d906ee19 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b