Issue 3222041: Add render type to GadgetHandler metadata request

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3222041: Add render type to GadgetHandler metadata request

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by zhoresh

Modified:
15 years, 3 months ago

Reviewers:
johnfargo, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

Add rendering type for request to support sanitize rendering. Added as enum so it can also handle Cajoled rendering soon. Value is specified using the "render" field in the request that take the enum name i.e: default, sanitized, iframe_cajoled, inline_cajoled Note that the proxy request also support sanitize and cajole, we might it consistent with the enum.

Patch Set 1 #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+48 lines, -0 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java	View	3 chunks	+20 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java	View	1 chunk	+8 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java	View	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

zhoresh

15 years, 3 months ago (2010-11-22 22:24:26 UTC) #3

Thanks. Submitted as r1037920


On Mon, Nov 22, 2010 at 1:45 PM, <johnfargo@gmail.com> wrote:

> LGTM
>
>
> On 2010/11/19 17:16:55, zhoresh wrote:
>
>
>
> http://codereview.appspot.com/3222041/
>

Expand All Messages | Collapse All Messages