Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(100)

Issue 321820043: ui/gtk3: Enable to type multiple code points on Emojier (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by fujiwara
Modified:
9 years, 2 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ui/gtk3: Enable to type multiple code points on Emojier - Can type multiple Unicode characters with digits and Shift-space keys. E.g. "1f468 1f468 1f466" - Always show Unicode points of the selected emoji - Removed a function to commit an emoji by typing a digit char since it conflicts with digit annotations, code points but it had enabled with single digits only so not so useful. R=Shawn.P.Huang@gmail.com Committed: 8b6f9fa531aa9d9b5d6c0184b2294d071f920d7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -109 lines) Patch
M ui/gtk3/emojier.vala View 17 chunks +98 lines, -109 lines 0 comments Download

Messages

Total messages: 3
fujiwara
9 years, 3 months ago (2017-03-29 12:50:27 UTC) #1
Peng
On 2017/03/29 12:50:27, fujiwara wrote: lgtm
9 years, 2 months ago (2017-03-29 14:01:53 UTC) #2
fujiwara
9 years, 2 months ago (2017-03-30 03:08:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8b6f9fa531aa9d9b5d6c0184b2294d071f920d7f (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b