Issue 321710043: ui/gtk3: Unset GDK_CORE_DEVICE_EVENTS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 321710043: ui/gtk3: Unset GDK_CORE_DEVICE_EVENTS (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 7 months ago by fujiwara

Modified:
6 years, 7 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

ui/gtk3: Unset GDK_CORE_DEVICE_EVENTS Plasma deskop sets this variable and prevents Super-space and Ctrl-Shift-e when ibus-ui-gtk3 runs after the desktop is launched. Also fixed a SEGV in display.get_monitor_at_window() Regression from rhbz#226465 R=Shawn.P.Huang@gmail.com Committed: d37c8bbdf9164ca76fb5ca513891e48273556881

Patch Set 1 #

Patch Set 2 : Fixed a typo #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	ui/gtk3/application.vala	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	ui/gtk3/switcher.vala	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

6 years, 7 months ago (2017-09-26 02:42:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d37c8bbdf9164ca76fb5ca513891e48273556881 (presubmit successful).

Expand All Messages | Collapse All Messages