Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(232)

Issue 321530043: bus: ibus-daemon activates ibus-portal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by fujiwara
Modified:
6 years, 7 months ago
Reviewers:
shawn.p.huang, Peng
CC:
alexl_redhat.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

bus: ibus-daemon activates ibus-portal When ibus-daemon restarts, ibus-portal exits with on_name_lost() and the clients wait for portal_name_appeared() until ibus-poral restarts. Now the clients can connect to ibus-daemon with this way and also they don't have to activate ibus-portal. BUG=https://github.com/flatpak/flatpak/issues/675 R=Shawn.P.Huang@gmail.com Committed: 9937a0e4501ccf0cfd238ce7c97733c3099db3f7

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated with comment #4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -7 lines) Patch
M bus/server.c View 2 chunks +43 lines, -2 lines 0 comments Download
M portal/portal.c View 1 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 6
fujiwara
6 years, 8 months ago (2017-08-31 03:13:01 UTC) #1
Peng
https://codereview.appspot.com/321530043/diff/1/portal/portal.c File portal/portal.c (right): https://codereview.appspot.com/321530043/diff/1/portal/portal.c#newcode104 portal/portal.c:104: #if 0 what is it?
6 years, 7 months ago (2017-08-31 11:03:09 UTC) #2
fujiwara
https://codereview.appspot.com/321530043/diff/1/portal/portal.c File portal/portal.c (right): https://codereview.appspot.com/321530043/diff/1/portal/portal.c#newcode104 portal/portal.c:104: #if 0 On 2017/08/31 11:03:09, Peng wrote: > what ...
6 years, 7 months ago (2017-08-31 11:10:09 UTC) #3
Peng
https://codereview.appspot.com/321530043/diff/1/portal/portal.c File portal/portal.c (right): https://codereview.appspot.com/321530043/diff/1/portal/portal.c#newcode104 portal/portal.c:104: #if 0 On 2017/08/31 11:10:09, fujiwara wrote: > On ...
6 years, 7 months ago (2017-09-01 10:51:42 UTC) #4
Peng
On 2017/09/01 10:51:42, Peng wrote: > https://codereview.appspot.com/321530043/diff/1/portal/portal.c > File portal/portal.c (right): > > https://codereview.appspot.com/321530043/diff/1/portal/portal.c#newcode104 > ...
6 years, 7 months ago (2017-09-01 10:52:06 UTC) #5
fujiwara
6 years, 7 months ago (2017-09-04 03:19:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9937a0e4501ccf0cfd238ce7c97733c3099db3f7 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b